Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Sep 2022 17:34:07 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     "GONG, Ruiqi" <gongruiqi1@huawei.com>
Cc:     <richard@nod.at>, <vigneshr@ti.com>,
        <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <wangweiyang2@huawei.com>
Subject: Re: [PATCH] mtd: rawnand: denali: Fix a possible resource leak in
 denali_pci_probe
Message-ID: <20220919173407.7068709a@xps-13>
In-Reply-To: <20220801080315.1713934-1-gongruiqi1@huawei.com>
References: <20220801080315.1713934-1-gongruiqi1@huawei.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Ruiqi,

gongruiqi1@huawei.com wrote on Mon, 1 Aug 2022 16:03:15 +0800:

> Call pci_release_regions() to retrieve the allocated resource when
> devm_ioremap() or denali_init() failed.

				  fail
>=20
> Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
> ---
>  drivers/mtd/nand/raw/denali_pci.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/mtd/nand/raw/denali_pci.c b/drivers/mtd/nand/raw/den=
ali_pci.c
> index de7e722d3826..40943cda0914 100644
> --- a/drivers/mtd/nand/raw/denali_pci.c
> +++ b/drivers/mtd/nand/raw/denali_pci.c
> @@ -74,21 +74,22 @@ static int denali_pci_probe(struct pci_dev *dev, cons=
t struct pci_device_id *id)
>  		return ret;
>  	}
> =20
> +	ret =3D -ENOMEM;

I don't like so much this construction as later changes in the probe
might just fail this logic.

Please just set ret =3D -ENOMEM; in the error path each time it's needed.
I don't care about loosing 3 lines of code if it clarifies what the
error path returns.

>  	denali->reg =3D devm_ioremap(denali->dev, csr_base, csr_len);
>  	if (!denali->reg) {
>  		dev_err(&dev->dev, "Spectra: Unable to remap memory region\n");
> -		return -ENOMEM;
> +		goto out_release_pci;
>  	}
> =20
>  	denali->host =3D devm_ioremap(denali->dev, mem_base, mem_len);
>  	if (!denali->host) {
>  		dev_err(&dev->dev, "Spectra: ioremap failed!");
> -		return -ENOMEM;
> +		goto out_release_pci;
>  	}
> =20
>  	ret =3D denali_init(denali);
>  	if (ret)
> -		return ret;
> +		goto out_release_pci;
> =20
>  	nsels =3D denali->nbanks;
> =20
> @@ -116,6 +117,8 @@ static int denali_pci_probe(struct pci_dev *dev, cons=
t struct pci_device_id *id)
> =20
>  out_remove_denali:
>  	denali_remove(denali);
> +out_release_pci:
> +	pci_release_regions(dev);
>  	return ret;
>  }
> =20


Thanks,
Miqu=C3=A8l