In-Reply-To: <467915DD.7020906@grupopie.com>
References: <4678013C.5090402@grupopie.com> <a781481a0706191147x72be6357vf0c83808b13174b8@mail.gmail.com> <200706200033.16708.vapier@gentoo.org> <467915DD.7020906@grupopie.com>
Mime-Version: 1.0 (Apple Message framework v623)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <c8d2863984d16e31de2aaed038b7367a@kernel.crashing.org>
Content-Transfer-Encoding: 7bit
Cc: Mike Frysinger <vapier@gentoo.org>,
       Satyam Sharma <satyam.sharma@gmail.com>, Andrew Morton <akpm@osdl.org>,
       linux-kernel <linux-kernel@vger.kernel.org>
From: Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: [PATCH] remove usage of memmem from scripts/kallsyms.c
Date: Wed, 20 Jun 2007 17:25:37 +0200
To: Paulo Marques <pmarques@grupopie.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 907
Lines: 24

>>> So we could remove the "#define _GNU_SOURCE" at the top
>>> of scripts/kallsyms.c too, presumably? If not (i.e. if there are
>>> more GNUisms left in that file anyway), then I'm not sure if we
>>> really gain by the change.
>> yes, i believe this is true
>
> I only tried in on x86 with my toolchain and it works, but I don't 
> know if it is worth the risk of breaking someone's setup for virtually 
> no gain...

With the memmem() removed, the code builds (and works)
fine on several non-GNU systems.  It should be perfectly
safe to remove the _GNU_SOURCE.  Perhaps you should
replace it with the proper POSIX_ define so it won't
be broken again?


Segher

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/