Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Sep 2022 17:57:49 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
Cc:     Adrian Zaharia <Adrian.Zaharia@windriver.com>,
        linux-mtd@lists.infradead.org, richard@nod.at, vigneshr@ti.com,
        jani.nurminen@windriver.com, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH 1/1] mtd: mtdpart: Fix cosmetic print
Message-ID: <20220919175749.6ba76d13@xps-13>
In-Reply-To: <43059215-aa56-e8c5-53a4-143643058797@gmail.com>
References: <20220825060407.335475-1-Adrian.Zaharia@windriver.com>
        <20220825060407.335475-2-Adrian.Zaharia@windriver.com>
        <43059215-aa56-e8c5-53a4-143643058797@gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello,

zajec5@gmail.com wrote on Tue, 13 Sep 2022 09:37:21 +0200:

> On 25.08.2022 08:04, Adrian Zaharia wrote:
> > From: Jani Nurminen <jani.nurminen@windriver.com>
> >=20
> > The print of the MTD partitions during boot are off-by-one for the size.
> > Fix this and show the real last offset. =20
>=20
> I see that PCI subsystem and printk() + %pR do that. Probably more. I
> guess it makes sense but I'm also wondering if/how confusing is that
> change going to be for users. We did printing like that for probably
> dozens of years.

Agreed, I would rather not mess with this output which might be
considered part of the ABI, I am sure there are plenty of scripts out
there which do silly things with those lines :-)

>=20
>=20
> > Fixes: 3d6f657ced2b ("mtd: mtdpart: Fix cosmetic print") =20
>=20
> I can't find that hash / commit anywhere. Are you sure it exists?
>=20
>=20
> > Signed-off-by: Jani Nurminen <jani.nurminen@windriver.com>
> > Signed-off-by: Adrian Zaharia <Adrian.Zaharia@windriver.com>
> > ---
> >   drivers/mtd/mtdpart.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
> > index d442fa94c872..fab10e6d4171 100644
> > --- a/drivers/mtd/mtdpart.c
> > +++ b/drivers/mtd/mtdpart.c
> > @@ -118,7 +118,7 @@ static struct mtd_info *allocate_partition(struct m=
td_info *parent,
> >   		child->part.size =3D parent_size - child->part.offset; =20
> >   >   	printk(KERN_NOTICE "0x%012llx-0x%012llx : \"%s\"\n", =20
> > -	       child->part.offset, child->part.offset + child->part.size,
> > +	       child->part.offset, child->part.offset + child->part.size - 1,
> >   	       child->name); =20
> >   >   	/* let's do some sanity checks */ =20
>=20


Thanks,
Miqu=C3=A8l