Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Zeng Jingxiang <zengjx95@gmail.com>, miquel.raynal@bootlin.com,
        richard@nod.at, vigneshr@ti.com
Cc:     linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        Zeng Jingxiang <linuszeng@tencent.com>
Subject: Re: [PATCH] mtd: physmap-core: Fix NULL pointer dereferencing in of_select_probe_type()
Date:   Mon, 19 Sep 2022 18:16:04 +0200
Message-Id: <20220919161604.226569-1-miquel.raynal@bootlin.com>
In-Reply-To: <20220727060302.1560325-1-zengjx95@gmail.com>
References: 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 2022-07-27 at 06:03:02 UTC, Zeng Jingxiang wrote:
> From: Zeng Jingxiang <linuszeng@tencent.com>
> 
> Coverity complains of a possible NULL dereference:
> 
> in of_select_probe_type():
> 1. returned_null: of_match_device() returns NULL.
> 2. var_assigned: match = NULL return value from of_match_device()
> 309	match = of_match_device(of_flash_match, &dev->dev);
> 
> 3.dereference: Dereferencing the NULL pointer match.
> 310	probe_type = match->data;
> 
> Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel