Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Kumaravel.Thiagarajan@microchip.com>
To:     <christophe.jaillet@wanadoo.fr>, <arnd@arndb.de>,
        <gregkh@linuxfoundation.org>
CC:     <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>
Subject: RE: [PATCH 3/3] misc: microchip: pci1xxxx: Fix the error handling
 paths of gp_aux_bus_probe()
Thread-Topic: [PATCH 3/3] misc: microchip: pci1xxxx: Fix the error handling
 paths of gp_aux_bus_probe()
Thread-Index: AQHYyyfVbIzjIzDakEyLcYGvw1j8Vq3nBpAg
Date:   Mon, 19 Sep 2022 17:47:32 +0000
Message-ID: <BN8PR11MB3668AE58BC463106D4BE57EFE94D9@BN8PR11MB3668.namprd11.prod.outlook.com>
References: <cover.1663482259.git.christophe.jaillet@wanadoo.fr>
 <1b41531de02ee029628d9b0ec2cf1ee7f180fe10.1663482259.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <1b41531de02ee029628d9b0ec2cf1ee7f180fe10.1663482259.git.christophe.jaillet@wanadoo.fr>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GGptpTZ8U+a/k6Apq9taWwRyD1GNrRFmZ1GJUqv9ikJAoLPQKu3E4eEWSvWH?=
 =?us-ascii?Q?kYKGw0gi7oPBtiqZbEVV5vWTgQNOsWBlkiXeRibvhFiaj5CPPPEKLb8J7nii?=
 =?us-ascii?Q?m+sqkcjqMGGzuDxT2lt+nirEuHDt2+v1O2rr6wDeqTI+dAU1hih2+WnSKdut?=
 =?us-ascii?Q?o0r4KvsVHc6XQOOl73iutMiW7nstd3nnbY7ICO9rnWVwRzUvNL0ASuq6RM0d?=
 =?us-ascii?Q?42VZW0kEdMiD6bEbBybG/Mudg1CZFJrNJzCHuHBHFGFqFDrrBlkXUIB1E2oU?=
 =?us-ascii?Q?ygjulxSlRkJwdnye3H8JVHJyBvvjzo8yTry8JxmWP0k5frj7JqyLeB5rKVHo?=
 =?us-ascii?Q?kHOhLqJoo9bHNY7UD3fgFszp83yrcOLb8KBqymPVcDKxnTIUWQSImYKEi1iL?=
 =?us-ascii?Q?p8NPFnxUZu7IWohGegEsyi/HemRoW7vBIgAon9cv7cowZNJ0pNPfJG8sUME9?=
 =?us-ascii?Q?jlktLuYnWKFjzSOn+B9yP3hqt14u/eFSmnTafWQULbMyA7Lo+KXZg+2DXeYu?=
 =?us-ascii?Q?SEsbEU7zwAEy0inJe+pd3fG9v4zdK1iWakgqumAHM/iz4igqag2NS1q245Eh?=
 =?us-ascii?Q?HqMufeaHko1Ja7sESPohC/C5h3D790wnGJunCSrHvWAARiwKLSRItLA8l0va?=
 =?us-ascii?Q?6wTC5NXI4NIW2sNtZ3zZ/PCzGEs8M1rF0E1iJaKgQ0C7kpmHtNhN1JoZDTVU?=
 =?us-ascii?Q?09Lf1+QnSb6XIL+YqykzIPP970EBXnKbfmapKFOPDOiHvY9BBXTmlweUzSt0?=
 =?us-ascii?Q?BuWkjZEdZE0RI68oJRzlsrA+8XjAjz+D8hqAgoT6y1AB6Qs7erNacWajPWgH?=
 =?us-ascii?Q?YZwVEnGtbJF1ZySZtjY+JjgNsnmk4gTMcfKb8fJ+6LAWmoM/zPwNND/tY+M7?=
 =?us-ascii?Q?6/EnKdrUnVdybu8X1APCAwWSAUZoxduYMORa7/BV26X72ACaCM6QYuuPUAx9?=
 =?us-ascii?Q?Ulv6l02vmH0XjvKddlojljkvWhHUQTv/f8baR+WICA8HYbjelp5oNtDY9+3o?=
 =?us-ascii?Q?d8k9g1Vk/YLaUEWmAv+xA7ywPGxEEDft+WbUxM9Q+En2zkzadVqQacxQXV38?=
 =?us-ascii?Q?Zp4aaQ96ACAF54PPu+IRnPODrz9epnrsEB+KMDqIkWFP+dMo2EMDUW0ojtHc?=
 =?us-ascii?Q?nqoglgcblVnrgOvMQ6I2LjUVyWdRGL/DIw06WnCSwoNgbQuL0leD5ZOPZs0w?=
 =?us-ascii?Q?MXizsQH3KUptPCjInYTaU4UHVIqeyNTEnju+zN0o6REPaLDIO+hjyWvPDSkJ?=
 =?us-ascii?Q?DdApOHy415uwj5zmKG7s/3jJqtcViYXDQkt0xSKIkY+jhq703JdE+NSojX1D?=
 =?us-ascii?Q?BUZA7a2FaWp4A6Vh3+v3423qE3BjFcjCL5EvTdKwurdV7WSmygXGupwtm0kd?=
 =?us-ascii?Q?WDE6kNRtbFMjQXConz5rGeRo/dgnRporjDzS+vuMQuxXFtCRI7Fg23By6WDM?=
 =?us-ascii?Q?k7Pjsx/+uBGsICQF0spRn7ZKlsP1MY7DZOT/j9Acy+L0pPS0nwsYfSO30vGT?=
 =?us-ascii?Q?Bb5pFOvXVySdI4vuODzLcOcqaUuXNQ+VA9cuOnAPDwn3jnxymuoEx10GVZac?=
 =?us-ascii?Q?o0OhJeCOEajSe8tHAs5y7anqqtSlK33jZ9beqYnagj39Y3pOxKbMjic5OEHN?=
 =?us-ascii?Q?QEgJS3mTTmYg6aK7FthriPY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3668.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c56e038-b6a0-4e5b-0b94-08da9a670793
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2022 17:47:32.5420
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iAG0jPvEKTC6xBfMp/0p2WV/R2oTNlVywILs3AJ9TOCStUAqjJrE/I7axCUoqczUi2jE2dFh/0pF23vq80tlnw8/Pt9LfdV2jqlhs0/PxNoQfMjLZ2dljbBjbdeFrSGC
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5952
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Sent: Sunday, September 18, 2022 11:58 AM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@microchip.com>; Arnd Bergmann
> <arnd@arndb.de>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org;
> Christophe JAILLET <christophe.jaillet@wanadoo.fr>; linux-
> gpio@vger.kernel.org
> Subject: [PATCH 3/3] misc: microchip: pci1xxxx: Fix the error handling pa=
ths
> of gp_aux_bus_probe()
>=20
> There are several issues related to the error handling paths of
> gp_aux_bus_probe():
>    - some resources may be released twice. Once explicitly in the error
>      handling path, and once via the release() function
>    - auxiliary_device_delete() should be called after the first successfu=
l
>      auxiliary_device_add()
Thanks for your patch. I had noticed this after one of the reviewers had on=
ly partially fixed them
up. I need some time to review and test your patch with the hardware before=
 approving them.

>=20
> To fix them, reorder the code:
>    - move the place where we get the irq for the 2nd wrapper.
>    - call kfree() and ida_free() after error checks, rather then in the
>      error handling path.
>    - have the error handling path look like the remove function
>=20
> Fixes: 393fc2f5948f ("misc: microchip: pci1xxxx: load auxiliary bus drive=
r for
> the PIO function in the multi-function endpoint of pci1xxxx device.")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This patch is speculative and untested, review with care.
>=20
> Other solutions are possible.
> For example, we could use devm_kzalloc() to simplify the error handling p=
ath
> and the release function.
I thought about this but had some doubts whether it will work with the auxi=
liary bus
architecture as the memory allocated will get tagged with the same device p=
ointer.
I need to do some experiments before taking up this path.

Thank You.

Regards,
Kumar