Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2866347rwb; Mon, 19 Sep 2022 11:08:11 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5OCt18dB21o570tt/+66WxCy8gl/yHdWa/Oki1Q66/TAD7FwvO4hOET9TBpvNWfx6LU3uO X-Received: by 2002:a17:902:d384:b0:178:60a9:8f19 with SMTP id e4-20020a170902d38400b0017860a98f19mr919379pld.141.1663610891274; Mon, 19 Sep 2022 11:08:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663610891; cv=none; d=google.com; s=arc-20160816; b=wOTB5j7nGAzGHKkN6IORzUsbaffNlfMew+u4Os4sZ0elvE3eq/TSD29xVyGKDjLjzy 6+RWTzwIrchK3/7jNb/FKEfGTd1eRTULqRRn8vdqC0o7q8gVzEAspgHrKNRpOPmf697s jkFqYwKmZCX47HF4cME+DEogfCjfZaTrkbBrX9syEbgMk+pWzRPx4fGNJpMaDwU4dYlb 0H69UkfRxmrtfdQjvhUCBF815HlEFMEC3wO6t+7pSZxQ8IeYuT9DPDPzQ9WvVrnF2lJt CNxBTwLDeCVPqp0685kdXDeSV8f0Pxxsswu7MVlstNm9/xnq2EI+NkcY7+MuSB56ccDZ 4kUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RHYhN10UNLl/si1/WlFv4gYdvkoiXlMPq3wkOww05uc=; b=xQBWWescoEBb8MsJAEuhV9bJ/QX6IoN3EYxHTvxli5TrPHp2w04Qu3/X/ia3hSKYsN DNmxerOG3AIlgxLwMBZ1+APNts5LXUBQe3EO69OzFKSiKjCWy/oFgfHQMXEv8Q1tjw4Q spzcXOUrNFobTsFgs+Lo70j8ACExD9MCPsRZ7PIVXJskg/p7r8+B+IagQhSGuXiQqSn2 m9mw3sxL+sFUf1v/qRMOqS7R2D6YNNN800dKhefAJzaUYAxkFSHaPeSKLPZTuJ1iWrWS bq5VRGg6EsJt+/lNTTugi2xjK5HEdq7BusekNNRwA6NrcQr3Zz18cWrSg2ECMMJ4i6Ki +avg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=h54gujbR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c1-20020aa79521000000b00535c451053esi28997822pfp.296.2022.09.19.11.07.57; Mon, 19 Sep 2022 11:08:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=h54gujbR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230113AbiISQ4o (ORCPT + 99 others); Mon, 19 Sep 2022 12:56:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229971AbiISQ4U (ORCPT ); Mon, 19 Sep 2022 12:56:20 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 877C031EE0; Mon, 19 Sep 2022 09:56:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663606579; x=1695142579; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=PD0OEq48XmwGRGo7+KydN6K0YxBdtfJGSm7xD4mIbZs=; b=h54gujbRMIreZsT1CjWEVRZMiumtfTF0DOvpLTyogR/L0KuG8XkmNzsJ ykTOjw0mOxwVIJmPKjEOCE/fihjbXusuWXTa2sgCEsPFeHeHtuoPgvVlK G+04sJFhIB7TKJZUUmQZ0v4A4ilQ6vs5IWphpwM1A9qFYA2ULzfDV7zoG RbRqHBvxgQccic/DeOGT0ZNTUvoIkYYEzmb7WFeaqWEjlzJUVANzlPV0w oSYx4WllE+aQo3YHZ+OW+WAQyrh6p7g73yWrDKR74dcYP0zgbHf2vfteK t/CXF/w2Kd+wUbH3pgv8sYiZ4lk4Cu4EErRNSF6ErrDOi6FCccrkfhO2K Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10475"; a="279185255" X-IronPort-AV: E=Sophos;i="5.93,328,1654585200"; d="scan'208";a="279185255" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2022 09:56:19 -0700 X-IronPort-AV: E=Sophos;i="5.93,328,1654585200"; d="scan'208";a="569724188" Received: from smitavil-mobl.amr.corp.intel.com (HELO desk) ([10.209.120.248]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2022 09:56:18 -0700 Date: Mon, 19 Sep 2022 09:56:17 -0700 From: Pawan Gupta To: Hans de Goede Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Pavel Machek , Andrew Cooper , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Daniel Sneddon , antonio.gomez.iglesias@linux.intel.com Subject: Re: [PATCH 0/3] Check enumeration before MSR save/restore Message-ID: <20220919165617.mpt2llkeglc2254e@desk> References: <20220913005053.vk7qmhr6tqqynags@desk> <5097a283-6111-bedc-13c6-61a581f8b72c@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5097a283-6111-bedc-13c6-61a581f8b72c@redhat.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 17, 2022 at 01:42:13PM +0200, Hans de Goede wrote: > Hi, > > On 9/13/22 02:50, Pawan Gupta wrote: > > On Mon, Sep 12, 2022 at 04:38:44PM -0700, Pawan Gupta wrote: > >> Hi, > >> > >> This patchset is to fix the "unchecked MSR access error" [1] during S3 > >> resume. Patch 1/3 adds a feature bit for MSR_IA32_TSX_CTRL. > >> > >> Patch 2/3 adds a feature bit for MSR_AMD64_LS_CFG. > >> > >> Patch 3/3 adds check for feature bit before adding any speculation > >> control MSR to the list of MSRs to save/restore. > >> > >> [1] https://lore.kernel.org/lkml/20220906201743.436091-1-hdegoede@redhat.com/ > > > > Added the correct email-id of Hans de Goede . > > I have tested this series and I can confirm that it fixes the exception > which I was seeing on a Packard Bell Dot SC with an Atom N2600 CPU: > > Tested-by: Hans de Goede Thanks.