Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755791AbXFTQmA (ORCPT ); Wed, 20 Jun 2007 12:42:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753334AbXFTQlx (ORCPT ); Wed, 20 Jun 2007 12:41:53 -0400 Received: from pasmtpb.tele.dk ([80.160.77.98]:49977 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753382AbXFTQlw (ORCPT ); Wed, 20 Jun 2007 12:41:52 -0400 Date: Wed, 20 Jun 2007 18:42:55 +0200 From: Sam Ravnborg To: Paulo Marques Cc: Segher Boessenkool , Mike Frysinger , Satyam Sharma , Andrew Morton , linux-kernel Subject: Re: [PATCH] remove usage of memmem from scripts/kallsyms.c Message-ID: <20070620164255.GA11519@uranus.ravnborg.org> References: <4678013C.5090402@grupopie.com> <200706200033.16708.vapier@gentoo.org> <467915DD.7020906@grupopie.com> <46794D6B.9050301@grupopie.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46794D6B.9050301@grupopie.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1512 Lines: 39 On Wed, Jun 20, 2007 at 04:53:15PM +0100, Paulo Marques wrote: > Segher Boessenkool wrote: > >>>>So we could remove the "#define _GNU_SOURCE" at the top > >>>>of scripts/kallsyms.c too, presumably? If not (i.e. if there are > >>>>more GNUisms left in that file anyway), then I'm not sure if we > >>>>really gain by the change. > >>>yes, i believe this is true > >> > >>I only tried in on x86 with my toolchain and it works, but I don't > >>know if it is worth the risk of breaking someone's setup for virtually > >>no gain... > > > >With the memmem() removed, the code builds (and works) > >fine on several non-GNU systems. It should be perfectly > >safe to remove the _GNU_SOURCE. > > You're right. I went back in history and it was me who introduced the > _GNU_SOURCE when I added the memmem too (shame on me). So, if it worked > fine before, there is no reason to not work now that memmem is removed. > > So I can: > > - send an incremental patch with just that line removed > > - send a replacement patch > > - just leave it for now and wait until I work on kallsyms again to > silently remove that line together with other changes > > Andrew, what would you prefer? Please send a replacement patch to me. I will carry it in the kbuild tree. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/