Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752653AbXFTRHB (ORCPT ); Wed, 20 Jun 2007 13:07:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753798AbXFTRGy (ORCPT ); Wed, 20 Jun 2007 13:06:54 -0400 Received: from mtoichi12.ns.itscom.net ([219.110.2.182]:44145 "EHLO mtoichi12.ns.itscom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753154AbXFTRGx (ORCPT ); Wed, 20 Jun 2007 13:06:53 -0400 Date: Thu, 21 Jun 2007 02:06:18 +0900 From: Mattia Dongili To: Thomas Renninger Cc: Len Brown , linux-kernel , linux-acpi , Henrique de Moraes Holschuh Subject: Re: [PATCH 3/3] ACPI autoloading - Create __mod_acpi_device_table symbol for all acpi drivers. Message-ID: <20070620170617.GA3226@inferi.kami.home> References: <1182112047.4204.12.camel@noname> <1182111863.4204.6.camel@noname> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1182111863.4204.6.camel@noname> X-Message-Flag: Cranky? Try Free Software instead! X-Operating-System: Linux 2.6.22-rc5-2 i686 X-Editor: Vim http://www.vim.org/ X-Disclaimer: Buh! User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1927 Lines: 59 On Sun, Jun 17, 2007 at 10:24:23PM +0200, Thomas Renninger wrote: > Create __mod_acpi_device_table symbol for all acpi drivers. > > modpost is going to use this one to create modules.alias > > Hopefully thinkpad module still works. > IMO this one should get restructured and make use of acpi_bus_register_driver > and try to avoid to test for HIDs/CIDs for its own. > > Signed-off-by: Thomas Renninger Tested, except for the compile error already reported it does its job on my vaios. A question though: > Index: linux-2.6.22-rc4/drivers/misc/sony-laptop.c > =================================================================== > --- linux-2.6.22-rc4.orig/drivers/misc/sony-laptop.c > +++ linux-2.6.22-rc4/drivers/misc/sony-laptop.c > @@ -890,10 +890,22 @@ static int sony_nc_remove(struct acpi_de > return 0; > } > > +static const struct acpi_device_id sony_device_ids[] = { > + {SONY_NC_HID, 0}, > + {SONY_PIC_HID, 0}, > + {"", 0}, > +}; > +MODULE_DEVICE_TABLE(acpi, sony_device_ids); > + > +static const struct acpi_device_id sony_nc_device_ids[] = { > + {SONY_NC_HID, 0}, > + {"", 0}, > +}; > + ... > +static const struct acpi_device_id sony_pic_device_ids[] = { > + {SONY_PIC_HID, 0}, > + {"", 0}, > +}; > + is it really necessary to have those duplicate entries? Also, I guess that when this patch set is applied we also should declare sonypi obsolete as sony-laptop will grab the same device that sonypi wants (the SPIC one). sony-laptop has options to avoid doing that would make things clear to users. I still haven't received reports of mafunctioning vaios using the new sony-laptop instead of sonypi but 2.6.22 isn't final yet. -- mattia :wq! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/