Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3271520rwb; Mon, 19 Sep 2022 18:33:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5GNC7+s3MbSTlycxvDwBH1VLaVWRGQH17nVk0xYamAgbxAFHE7+3JKJgth4ijekDJ92Fix X-Received: by 2002:a17:90b:3ec7:b0:202:b984:8436 with SMTP id rm7-20020a17090b3ec700b00202b9848436mr1193648pjb.4.1663637583133; Mon, 19 Sep 2022 18:33:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663637583; cv=none; d=google.com; s=arc-20160816; b=ru7guuAGO5HMgMVwGx3IQjCd1bADT0b0mZmHHFm/PFNYWmrvP1YjizTTcd146wrt/N CHfu7UYA8X/gD0OppHjhUi3xygfinvPAQQB7k394u1iN3Le/A/lZ+LCwmGDc0PQOPEWs zJnxlJckVv/b096ptMsTxO2PK6b4Tc9TitKJIVBT2DJzBHOcBQkPw55K5wXeUyXmPuQS ZTSxfCOMy+UO4kSIMGOZLoxQh9kDcGBIn0nwOjwXB0D4DkpeS1kb8XMdKw5E8nSn0w/9 pcPGDfo3lPOwb1R9wvU+YFr62phdbu/ALy3OnSR3xpG44xVB7aD7EcnNq6En5Y00aANY QBkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=LlrwWSwwrQOfWqYPNpbzQ2CryxaZH3SQQFaCez0aRis=; b=eet8hsxFiGHaFNCT0ZqvwUB1w92ybQ4mtE5OO2tWqVLHXOHbKjm2bw2upa4jAG0g3R 7ew0yGGlhMFiEhWJ038cy7dSsGeKW0n+yfnZXuizuncfiqzmkTSX17lfiRm5LRVDRqrO Em3GiK/hzKZIp7TdyD73V0e0jIgKk6pio8QDDnot7gO9O9uzKsgeURpHOxO5ccsdyLLK 1+NOxxne/UT9+WORhANZVX4XCKvhhDhPKTLNqHVbWUeuJLPa3GCqbeIMS8aolt6/+64g As8w19a7VAFKD7e/o03Rj+OFqX/mSeFiOYAGlD0cRuox50thoAO3cQ0jrj2GoHmH4O0o Eohg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZxYdHRWp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s30-20020a63af5e000000b0043713026b3asi155704pgo.171.2022.09.19.18.32.51; Mon, 19 Sep 2022 18:33:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZxYdHRWp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229911AbiITB2k (ORCPT + 99 others); Mon, 19 Sep 2022 21:28:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229881AbiITB2i (ORCPT ); Mon, 19 Sep 2022 21:28:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 288684F67A; Mon, 19 Sep 2022 18:28:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DC977B822ED; Tue, 20 Sep 2022 01:28:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA62EC433D7; Tue, 20 Sep 2022 01:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663637314; bh=LlrwWSwwrQOfWqYPNpbzQ2CryxaZH3SQQFaCez0aRis=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZxYdHRWpGsLmCHTKJt7E7vueXYe4kLYCFoNtNt97TAc0uK4oYLcaOHIzmynn6unWt DBH+X/iCSR1UsAfMyC6N7/97BBASa+qV+N0MGXV4R2c+b3T5jSNdyM9idQEPb2c+WM vcxOykq2Ao0k2n41jFN16kOL0IZAcDaldqhEh7FrxlS/G2TAaZfw6yDdLtD4ZLYW21 HqOOhVCzgWgwhos/Gga8ML46gl75tG9NcWH+ZK3ZOo98G6yyeg6ziIL1gHrH8V+H95 5hE+gnYHqQiiN7urvPRX6Vxuxuzm6iAK5z4HF+Z9UBuQ0OZ1MLnR8fU0OgYYxdqtiO 9priXpCj3LPBA== Date: Mon, 19 Sep 2022 18:28:32 -0700 From: Jakub Kicinski To: Nathan Huckleberry Cc: Dan Carpenter , llvm@lists.linux.dev, "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , "David S. Miller" , Eric Dumazet , Paolo Abeni , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: mana: Fix return type of mana_start_xmit Message-ID: <20220919182832.158c0ea2@kernel.org> In-Reply-To: <20220912214357.928947-1-nhuck@google.com> References: <20220912214357.928947-1-nhuck@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Sep 2022 14:43:53 -0700 Nathan Huckleberry wrote: > -int mana_start_xmit(struct sk_buff *skb, struct net_device *ndev) > +netdev_tx_t mana_start_xmit(struct sk_buff *skb, struct net_device *ndev) This one has a prototype.