Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <20c47bd6742c08912c7b35e75c032c5b853fccde.camel@mediatek.com>
Subject: Re: [PATCH 1/2] stmmac: dwmac-mediatek: add support for mt8188
From:   Jianguo Zhang <jianguo.zhang@mediatek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        "David S . Miller" <davem@davemloft.net>,
        Rob Herring <robh+dt@kernel.org>
CC:     Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        "Biao Huang" <biao.huang@mediatek.com>, <netdev@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>
Date:   Tue, 20 Sep 2022 10:33:07 +0800
In-Reply-To: <b343e4c7-a247-28b8-3d16-cb7cea7ba36b@linaro.org>
References: <20220919080410.11270-1-jianguo.zhang@mediatek.com>
         <20220919080410.11270-2-jianguo.zhang@mediatek.com>
         <d28ce676-ed6e-98da-9761-ed46f2fa4a95@linaro.org>
         <4c537b63f609ae974dfb468ebc31225d45f785e8.camel@mediatek.com>
         <88412fcc-96be-cd9d-8805-086c7f09c03b@linaro.org>
         <f72e133e9aec70724702054e5f6a8712b649d34f.camel@mediatek.com>
         <b343e4c7-a247-28b8-3d16-cb7cea7ba36b@linaro.org>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Dear Krzysztof,

	Thanks for your comment.

On Mon, 2022-09-19 at 12:06 +0200, Krzysztof Kozlowski wrote:
> On 19/09/2022 11:56, Jianguo Zhang wrote:
> > > No, this does not justify new entry. You need specific
> > > compatible,
> > > but
> > > not new entry.
> > > 
> > > > On the other hand, mt8188 and mt8195 have same ethernet design,
> > > > so
> > > > the
> > > > private data "mt8195_gmac_variant" can be resued to reduce
> > > > redundant
> > > > info in driver.
> > > 
> > > And you do not need new entry in the driver.
> > 
> > Do you mean that I can use "mediatek,mt8195-gmac" as compatible for
> > ethernet in mt8188 DTS file?
> 
> Yes, as a fallback. Example schema describes such case.
> 
OK, we will drop the changes in patch #1 and add MT8188 related info in
binding document in next version patches.
> Best regards,
> Krzysztof
> 
BRS
Jianguo