Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3439345rwb; Mon, 19 Sep 2022 22:36:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4N7Mm+5W/1NrNBWeYQ+ANzDmJdYSQXpRZXRyP5lBlt/yNpwOVlmiRzh7/4Rpu4rCDjyVuf X-Received: by 2002:a17:906:fd82:b0:770:7e61:3707 with SMTP id xa2-20020a170906fd8200b007707e613707mr15172537ejb.143.1663652206179; Mon, 19 Sep 2022 22:36:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663652206; cv=none; d=google.com; s=arc-20160816; b=pLbLvqK7khZk1iz3x4xeTyCP/Gh4jrUgtwi/M/JhGJ+NSuBOhR318zz4QJtz3azeZW 9k+0KjJk22WR5xeeuv9hdZFVdNjH5R9lDBb0SWz1jg1x12jrKT93qq6oWXM3J8iz3Tlt UFUxuqv9UY2FPrw+I1yxbQyS/LTXOTpF1POhNerExZWKwkwvCgykdhKAadV3PPkpPI14 86/9psYqSrWwwpqa9kIl58ksgS0Xd9vta2r74LeHovFkwPf5j9ZLC4qyLlR3kI8+1yf7 Dd1ddV0zQhMhPsng5yg+3fruMOk1d4MyKZIF7aBRpGwc3FQ81R7MObPBMOxRjGAC4KAK Qp4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qYbUZ9ALf/SzfjQ5LkawOY2MU0hY7tra6GXp/HZuxsY=; b=B7Cknq/GFl7tAsuVKdUH7WM/vr0zfTzkgGf8FFDS8w7cw6fM4tTZ2Tx2d6p/GIfm+0 h4b7nwwRLlFtgbIDXIZWKvwtKsEAsVYuLlp3SbTDaEIfB19ZBd89yC8k4XVkdm2k3dr5 RPehYpkGjkzBX+s9PDyhuhsYthes4IxTFZfl/ILVpYbyHyj5d753RYcuUOwBuXEy4KZh Et7tupkYwBy/K7A3XykaAbAVMJEA2OOI5rVBWNlxJfXSW58yaB4q+3kvlqVzju1d/wgr 8m8J9+h48GOvbMOHGeUMkfmOAVoKJEsT6NTiXWRZZnNdmrQZIhXHtPq9e2gEUDpCXjPL +88w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=alEivXXa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y11-20020a056402440b00b0044eba28fe51si777816eda.279.2022.09.19.22.36.20; Mon, 19 Sep 2022 22:36:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=alEivXXa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229954AbiITFFF (ORCPT + 99 others); Tue, 20 Sep 2022 01:05:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbiITFFD (ORCPT ); Tue, 20 Sep 2022 01:05:03 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A66426ACC; Mon, 19 Sep 2022 22:05:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 18A61B82469; Tue, 20 Sep 2022 05:05:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 465BCC433C1; Tue, 20 Sep 2022 05:04:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663650299; bh=wnzt8PW3zP9wtrewvt5xUq0/W2ToEB86MUL4a6EzQ74=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=alEivXXaV7UE1FPN9+i6lHMvQP2Y35TWzGnpVSO3WlAf+WoMPOlV08+t10uNZAmA6 UQUSQfjdv0x1Mg3ErWUUZP2GXVQZFLoPJpwP30grxbu3FM8mojq6oWoqXWAWPE4JSW Q9DslhB7EwVpjekwVUEeAIMCWwRxxMvVaNxCHLVvVZzVgMaGXvNHyKyv7+Yt4XGO7k 4zHGFY1RThlLcALwNrOhntokSCtcqciIE75WEvvUKnnp5kNMWhjCoVhwC9eEJlG4ur 30a3agResor32XjxuoTFXacUYEzZRZSDEr9whTllllOID0U1sQWJ+wQthn2KTfl3wj 6Md58N9TCp+nQ== Date: Tue, 20 Sep 2022 10:34:55 +0530 From: Vinod Koul To: Srinivas Kandagatla Cc: yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, quic_srivasam@quicinc.com Subject: Re: [PATCH v2 1/2] soundwire: qcom: update status from device id 1 Message-ID: References: <20220916135352.19114-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220916135352.19114-1-srinivas.kandagatla@linaro.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16-09-22, 14:53, Srinivas Kandagatla wrote: > By default autoenumeration is enabled on QCom SoundWire controller > which means the core should not be dealing with device 0 w.r.t enumeration. > > During Enumeration if SoundWire core sees status[0] as SDW_SLAVE_ATTACHED and > start programming the device id, however reading DEVID registers return zeros > which does not match to any of the slaves in the list and the core attempts > to park this device to Group 13. This results in adding SoundWire device > with enumeration address 0:0:0:0 > > Fix this by not passing device 0 status to SoundWire core. Applied after fixing typi pointed by Pierre, thanks Also, pls check, I got conflict which was resolved -- ~Vinod