Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     "linus.walleij@linaro.org" <linus.walleij@linaro.org>
CC:     "brgl@bgdev.pl" <brgl@bgdev.pl>,
        "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "michael@walle.cc" <michael@walle.cc>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>,
        "conor.dooley@microchip.com" <conor.dooley@microchip.com>
Subject: RE: [PATCH] gpiolib: fix OOB access in quirk callbacks
Thread-Topic: [PATCH] gpiolib: fix OOB access in quirk callbacks
Thread-Index: AQHYzE0eCole2NyqQk+pDdYLxQQsuK3n02Ow
Date:   Tue, 20 Sep 2022 06:01:16 +0000
Message-ID: <OS0PR01MB59228A8B66C1EC28FCA9B8A9864C9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <960a9d86-7814-3b2f-d5a0-9bc2b316d12b@microchip.com>
 <1041bfe5-6515-feea-36d6-47f8f28938b6@samsung.com> (raw)
In-Reply-To: <1041bfe5-6515-feea-36d6-47f8f28938b6@samsung.com> (raw)
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KEod/7PKf80gN+A46HoNi4xdejFnlMsmFaeHcmqyGiSZJJARrlxhll67lKWj?=
 =?us-ascii?Q?Kotk9wxcDCj4T8KvUY/vJrggS8y3GL0Mey6w3Jo2Rsmdr6rF2/BGdDyzEwQz?=
 =?us-ascii?Q?IDaczRznM2wAZAPASomBuEn7Adp+g1Nbsoi9afRy1opC/aHqrsj51SgT9SON?=
 =?us-ascii?Q?dkfykxo0H7vOa/QVzDbecSSa/5xtK4JpEtLggNL2y93FsKSqeaqnAP4ChK0I?=
 =?us-ascii?Q?VxE71tRxtoGuwMCQ8QZGIkBUOsOL5T47qUyMgyA1MDNu/rCSfT135HxM2rjV?=
 =?us-ascii?Q?AS+sdE43hgyw/4AMnCORhFYCNGUf08Z9iZRm+u3+EDwjx42WYI5FalrstJjN?=
 =?us-ascii?Q?xGya+fdFmQZBF8GOO1R/euWoSnDjALJlklTWsVDFXH+YZwyhFumBe+/AHKpr?=
 =?us-ascii?Q?x9B9OS0I4eRvs7dF+TQIRuN2OHJRY/YUwipzm46qDtkD4N4PdFsHHqMq842L?=
 =?us-ascii?Q?Y5Ynl2fMN0JRecDQB1AXlImtiZ9n1cybD0JiP2GPJjc8pnIGmRRALbGc76mO?=
 =?us-ascii?Q?wtKJ/Zz/ibZKI6gEAFvdd/HJD8AmNMaUGqMRdotnu6JimjBWP+pWhblH7S2B?=
 =?us-ascii?Q?UzUzYpXvlhPpKLbT0XJq9PKkK3A+k05Cqph7Z8XgcZctA+cZvyEPNzfBMFrQ?=
 =?us-ascii?Q?W9JV7pB2akU8JxI5tm6afdRbB3T12YwEQ7TX6AVayWCarp7ABAyl8mNNoq6v?=
 =?us-ascii?Q?+QuVUK2ogMmzC6195m1a7hD0QNGut+ZINzecezEo/b/rt3CrtR9X5JecX/MO?=
 =?us-ascii?Q?2Prp0/lgC408cBoXfNWPamcC2kd4toqvtDGKKYvx3XmwHQkqwMaHmExU/Rlo?=
 =?us-ascii?Q?UX1m5fQR5xJ+C/xFLKQWmdb4QhnjoWwIXHXsWMIzFsWbUI2nBzhd6VRgxGvC?=
 =?us-ascii?Q?pNBgufR+MsA904UTlpg9SDL0ZYlCSEuMn+toPpaVmwdxFhZ9MfNkZojwE2mG?=
 =?us-ascii?Q?ER+izI4BrM494LV34DC3ER/4CqvYNwk+5RHFHuhRnEPJ8ImWOK0TADFqNNMN?=
 =?us-ascii?Q?nTnH/uOysfgT8g6CV0QqNqNMtlKTY8BSJE5Ch+E4bcWD27vJCNN8keC53S9y?=
 =?us-ascii?Q?jG3CqiIm5zatWMjKccrlB2YUM7un1mVxRf8l7mJiK2loPiWU9rHGaRTYbVLn?=
 =?us-ascii?Q?NKGbWapSbFaQWodcKRxUQ5Q77NU/qm8iUfrDnxHiFILXBmnJYQUJO+wWt5au?=
 =?us-ascii?Q?UDcCSMrEXwIu36t0KierS+8fmwzZ3O+U83v6MLdF1pWQ6w8lKn504zwqIV5W?=
 =?us-ascii?Q?7icF8LTDRw+sgrBqimGtYDKuBwpMWfEUJ2OBSpMepubzq+iisUr4Hjjr4iwh?=
 =?us-ascii?Q?QNl+ORFwYCnZwx4XqdCRSallnkvrWbvTqkiK6ZhGDQZTGZ7kxHvjbvBsXObf?=
 =?us-ascii?Q?YRtvsNbhxq3dLWCZXPxfRrM2xMXaUdIy4r/zkQbNuXWZ8Ba+otFD6WbkMpHz?=
 =?us-ascii?Q?CqpKtwUfJcdvJBNy0OsLkEKbNPj7/DJHYyWVuybzbzeyYVcrZ+rXt0zRFImq?=
 =?us-ascii?Q?nNsZHziG7opUEGsIXvA/HS9huHOBXJ47NVPXVBlZwqkEgUaR3nPwe2bGb1ZF?=
 =?us-ascii?Q?IBQZmCNDnaH96WfSANPDDmf96/rB2kHEDercmDvh74GhYOCOwQT1+0AH6DBW?=
 =?us-ascii?Q?hA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bee06081-3d55-4b53-c6fa-08da9acd87ca
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2022 06:01:16.3377
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /N3pPirtVj0CJco9CzHtRtVuhae9jrp8AKgM43s/M0TSXYgUxbQMaSrkVGXCRPiBb+8rh6kLx1Ss9xYUpTOnkEwD8yawVfqiR+HVTEg8dVY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB6220
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi All,

> Subject: Re: [PATCH] gpiolib: fix OOB access in quirk callbacks
>=20
> On 16.09.2022 13:01, Michael Walle wrote:
> > Commit a2b5e207cade ("gpiolib: rework quirk handling in
> > of_find_gpio()") introduced an array of quirk functions which get
> > iterated over. But a sentinal value is missing. Add it.
> >
> > Fixes: a2b5e207cade ("gpiolib: rework quirk handling in
> > of_find_gpio()")
> > Signed-off-by: Michael Walle <michael@walle.cc>
>=20
> This fixes the boot issue on RZ/G2L board since next-20220916.
>=20
> Tested-by: Biju Das <biju.das.jz@bp.renesas.com>
>=20
> > ---
> > FWIW here is the kernel oops backtrace:
> > [    4.108706] Internal error: SP/PC alignment exception: 8a000000
> [#1] SMP
> > [    4.115470] Modules linked in:
> > [    4.118549] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.0.0-rc5-
> next-20220916-00091-g6cae0fcbd5e7 #1821
> > [    4.128033] Hardware name: Kontron KBox A-230-LS (DT)
> > [    4.133127] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS
> BTYPE=3D--)
> > [    4.140154] pc : 0x61722d6f697067
> > [    4.143495] lr : of_find_gpio+0x138/0x174
> > [    4.147546] sp : ffff80000a24b680
> > [    4.150884] x29: ffff80000a24b680 x28: 0000000000000000 x27:
> ffff80000996044c
> > [    4.158090] x26: 0000000000000001 x25: ffff80000970f588 x24:
> ffff800009297968
> > [    4.165295] x23: ffff80000a24b770 x22: 0000000000000000 x21:
> ffff0020009a7010
> > [    4.172500] x20: ffff8000097752f8 x19: fffffffffffffffe x18:
> 0000000000000000
> > [    4.179703] x17: ffff8000085fb9d0 x16: ffff8000085fb264 x15:
> ffff8000085f96ac
> > [    4.186907] x14: 0000000000000000 x13: ffff80000884b3e8 x12:
> ffff80000884ab04
> > [    4.194111] x11: ffff80000884aa54 x10: 0000000000025080 x9 :
> ffff8000085fce78
> > [    4.201316] x8 : 0101010101010101 x7 : ffff800009750268 x6 :
> 051f521459491b57
> > [    4.208520] x5 : 571b495914521f05 x4 : 6e61722d6f697067 x3 :
> ffff80000a24b6d4
> > [    4.215724] x2 : 0000000000000000 x1 : ffff8000097752f8 x0 :
> ffff00207f7e4b20
> > [    4.222928] Call trace:
> > [    4.225389]  0x61722d6f697067
> > [    4.228377]  gpiod_get_index+0x12c/0x440
> > [    4.232334]  devm_gpiod_get_index+0x34/0xf0
> > [    4.236553]  devm_gpiod_get_optional+0x20/0x40
> > [    4.241036]  uart_get_rs485_mode+0x104/0x180
> > [    4.245345]  serial8250_register_8250_port+0x198/0x484
> > [    4.250532]  of_platform_serial_probe+0x358/0x640
> > [    4.255279]  platform_probe+0x70/0xe0
> > [    4.258973]  really_probe+0xc4/0x2e4
> > [    4.262577]  __driver_probe_device+0x80/0xec
> > [    4.266882]  driver_probe_device+0x44/0x150
> > [    4.271100]  __driver_attach+0x88/0x1a0
> > [    4.274967]  bus_for_each_dev+0x78/0xdc
> > [    4.278833]  driver_attach+0x2c/0x40
> > [    4.282437]  bus_add_driver+0x15c/0x210
> > [    4.286303]  driver_register+0x80/0x13c
> > [    4.290170]  __platform_driver_register+0x30/0x3c
> > [    4.294915]  of_platform_serial_driver_init+0x24/0x30
> > [    4.300013]  do_one_initcall+0x4c/0x240
> > [    4.303882]  kernel_init_freeable+0x29c/0x30c
> > [    4.308276]  kernel_init+0x2c/0x140
> > [    4.311793]  ret_from_fork+0x10/0x20
> > [    4.315401] Code: bad PC value
> >
> >   drivers/gpio/gpiolib-of.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> > index 95be5f0d2623..0e4e1291604d 100644
> > --- a/drivers/gpio/gpiolib-of.c
> > +++ b/drivers/gpio/gpiolib-of.c
> > @@ -498,6 +498,7 @@ static const of_find_gpio_quirk
> of_find_gpio_quirks[] =3D {
> >   	of_find_regulator_gpio,
> >   	of_find_arizona_gpio,
> >   	of_find_usb_gpio,
> > +	NULL
> >   };
> >
> >   struct gpio_desc *of_find_gpio(struct device *dev, const char
> > *con_id,
>=20

Can we revert the offending patch? or apply this patch

As the boards are not booting with Linux next since=20
next-20220916 tag.

Cheers,
Biju