Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Sep 2022 11:48:44 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc:     davem@davemloft.net, linux-phy@lists.infradead.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Russell King <linux@armlinux.org.uk>,
        UNGLinuxDriver@microchip.com, thomas.petazzoni@bootlin.com
Subject: Re: [PATCH net-next] phy: lan966x: add support for QUSGMII
Message-ID: <YylbRBPC+0JAvtQU@matsya>
References: <20220826141722.563352-1-maxime.chevallier@bootlin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220826141722.563352-1-maxime.chevallier@bootlin.com>
Precedence: bulk

On 26-08-22, 16:17, Maxime Chevallier wrote:
> Makes so that the serdes driver also takes QUSGMII in consideration.
> It's configured exactly as QSGMII as far as the serdes driver is
> concerned.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> ---
> 
> Dear netdev and Generic PHY maintainers,
> 
> This patch should go through the net-next tree instead of the generic
> PHY tree, as it has a dependency on :
> 
> 5e61fe157a27 "net: phy: Introduce QUSGMII PHY mode"
> 
> This commits only lives in the net-next tree as of today.
> 
> Given the simplicity of this patch, would that be OK for you ?


Sure:

Acked-By: Vinod Koul <vkoul@kernel.org>

> 
> Thanks,
> 
> Maxime
> 
>  drivers/phy/microchip/lan966x_serdes.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/phy/microchip/lan966x_serdes.c b/drivers/phy/microchip/lan966x_serdes.c
> index e86a879b92b5..d1a50fa81130 100644
> --- a/drivers/phy/microchip/lan966x_serdes.c
> +++ b/drivers/phy/microchip/lan966x_serdes.c
> @@ -401,6 +401,9 @@ static int serdes_set_mode(struct phy *phy, enum phy_mode mode, int submode)
>  	    submode == PHY_INTERFACE_MODE_2500BASEX)
>  		submode = PHY_INTERFACE_MODE_SGMII;
>  
> +	if (submode == PHY_INTERFACE_MODE_QUSGMII)
> +		submode = PHY_INTERFACE_MODE_QSGMII;
> +
>  	for (i = 0; i < ARRAY_SIZE(lan966x_serdes_muxes); i++) {
>  		if (macro->idx != lan966x_serdes_muxes[i].idx ||
>  		    mode != lan966x_serdes_muxes[i].mode ||
> -- 
> 2.37.2
> 
> 
> -- 
> linux-phy mailing list
> linux-phy@lists.infradead.org
> https://lists.infradead.org/mailman/listinfo/linux-phy

-- 
~Vinod