Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v2 -next] genirq: Separate warning messages of enable of
 suspended irq
To:     <tglx@linutronix.de>
CC:     <linux-kernel@vger.kernel.org>
References: <20220728102912.474772-1-chenlifu@huawei.com>
From:   chenlifu <chenlifu@huawei.com>
Message-ID: <05645307-3daa-a36f-fa86-34a7e2e8ae26@huawei.com>
Date:   Tue, 20 Sep 2022 14:42:11 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20220728102912.474772-1-chenlifu@huawei.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

?? 2022/7/28 18:29, Chen Lifu д??:
> Both unbalanced enable for irq and enable of suspended irq
> print same warning messages, such as:
> ......
> [20220314100142]------------[ cut here ]------------
> [20220314100142]WARNING: CPU: 1 PID: 10332 at kernel/irq/manage.c:723 __enable_irq+0x58/0xa4
> [20220314100142]Unbalanced enable for IRQ 38
> ......
> 
> It's confusing. Separate the warning messages to make it clear.
> No functional changes.
> 
> Signed-off-by: Chen Lifu <chenlifu@huawei.com>
> ---
>   kernel/irq/manage.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index 40fe7806cc8c..bf4f5f63b2d3 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -775,17 +775,19 @@ void disable_nmi_nosync(unsigned int irq)
>   
>   void __enable_irq(struct irq_desc *desc)
>   {
>   	switch (desc->depth) {
>   	case 0:
> - err_out:
>   		WARN(1, KERN_WARNING "Unbalanced enable for IRQ %d\n",
>   		     irq_desc_get_irq(desc));
>   		break;
>   	case 1: {
> -		if (desc->istate & IRQS_SUSPENDED)
> -			goto err_out;
> +		if (desc->istate & IRQS_SUSPENDED) {
> +			WARN(1, KERN_WARNING "Enable of suspended IRQ %d\n",
> +			     irq_desc_get_irq(desc));
> +			break;
> +		}
>   		/* Prevent probing on this irq: */
>   		irq_settings_set_noprobe(desc);
>   		/*
>   		 * Call irq_startup() not irq_enable() here because the
>   		 * interrupt might be marked NOAUTOEN. So irq_startup()
> 

Friendly ping ...