Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3541471rwb; Tue, 20 Sep 2022 00:48:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6s3XThBK3fEtr1q5saWnh3+PKoXIzqXKssbQpRD02UhLtsx6JZlC1RJPxeDcRgsFP5a6B/ X-Received: by 2002:a17:907:7fa5:b0:781:4add:3a21 with SMTP id qk37-20020a1709077fa500b007814add3a21mr7267507ejc.267.1663660099327; Tue, 20 Sep 2022 00:48:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663660099; cv=none; d=google.com; s=arc-20160816; b=PxB5whBjJKlkDlP+GUuS1iBEKFls4KF5Ii+YR277aTE3CvUbkFQcaZcr57TeXkq+rK ugQRqBJDm7byMVSBB2Qg/tsQuxBNERXCxyj9Q/Nz6fck7a0uYTCkrLfhyqXlsY1tgb57 yLw9rkZrcWJjX0CEvYh0G+G6Pi2wgujbyDcP9kOyUkRgm9mUrCkcWdsYDcl/15OkryN1 QIBvFDkSK+8nHOakxBL67eeZm2JMQiQu8WlCiu9KCS4aZRusY9tt8ae0/EORpDPtconA wkbYjDgz5jX0TLIhmHRXQ+KvkrpGuew3s5UPwfbpZcepzJH9abbE2qHXmlVO4cUmyMCb so3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qteLBBo7gVyIzY+cqTBV2I+NHOr6YHBw0FIcyQI9tp8=; b=YoLBkCUVkUPak2h4SmVaDy+djF6tNE8zq5qOjX5G7AL78lMbBRV4ExkarJqeMSNW/z rzf2fPY5vB6rLGDJkFXO1vGFIsEemgM+4L/EcZ44A+5vIwIkQKEzUSXAYTu5l9VoVO/S VXiQ1hA9WtmxVDYg2LBcFRAOD9VHnLQBG0e4+/fYn5VbOQGWHH5JXmM25WgbmZaHG6sp iL9LyFEQjAi7lO1BqF4ic5xoIE5xaGaKtAhToTqP7/zFrSDYHMzsCWcNRkuj/LCW28g6 sgLXATl4VVl8GrDvcZq5Ja9LRk3PXxilaZ+A7Otb6/pws8ve+kqci564fmaYt7De8uF+ uu9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="U3km51K/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hh5-20020a170906a94500b007808a356cb9si603831ejb.627.2022.09.20.00.47.53; Tue, 20 Sep 2022 00:48:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="U3km51K/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230232AbiITH0J (ORCPT + 99 others); Tue, 20 Sep 2022 03:26:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230230AbiITH0G (ORCPT ); Tue, 20 Sep 2022 03:26:06 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 231E951A35; Tue, 20 Sep 2022 00:26:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qteLBBo7gVyIzY+cqTBV2I+NHOr6YHBw0FIcyQI9tp8=; b=U3km51K/9URRR722eOD617czlB kqYZuclNDxR6GAVHQG3rJZMaxuqea8tUvU/koafALedar/8WuJg+KJyLEcsxoXQJByN3xPoakhMPJ McLagTM5reMYyM+mDumkJtDVs5/+tUkMbn5vLgLPvsygRLLzh8gJuUluxOZOtOZyrR1raZN8lIQor 0Msm8hPNHjhhNr4I5brlzrtuOyyRV2Xh/TkvUNtjgyfONhZ7B7LC3xcst135iXYeUB9hKvkX5Ej78 EomQxwVHT7hkQvUVfVUSIxO126iYx9NuGH/aSRN7sRx8oyBpXjRNwF6SuleSfBnyNEktiOCW7eQdy yKds+8xA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaXdh-001LTm-Vw; Tue, 20 Sep 2022 07:25:53 +0000 Date: Tue, 20 Sep 2022 00:25:53 -0700 From: Christoph Hellwig To: Yu Kuai Cc: paolo.valente@linaro.org, axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com Subject: Re: [PATCH v2 3/3] blk-wbt: don't enable throttling if default elevator is bfq Message-ID: References: <20220919070916.2738443-1-yukuai1@huaweicloud.com> <20220919070916.2738443-4-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220919070916.2738443-4-yukuai1@huaweicloud.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matching names is always is a bad idea. Just ad a flags field to elevator_mq_ops, add a DISABLE_WBT flag to it, and check for that and everything should become much, much simpler.