Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Sep 2022 10:10:22 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Tudor Ambarus <tudor.ambarus@microchip.com>
Cc:     <richard@nod.at>, <vigneshr@ti.com>, <novikov@ispras.ru>,
        <vasilyev@ispras.ru>, <kirill.shilimanov@huawei.com>,
        <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: rawnand: intel: Remove macro that is already
 defined in the core
Message-ID: <20220920101022.7bfa5304@xps-13>
In-Reply-To: <20220801025740.47191-1-tudor.ambarus@microchip.com>
References: <20220801025740.47191-1-tudor.ambarus@microchip.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Tudor,

tudor.ambarus@microchip.com wrote on Mon, 1 Aug 2022 05:57:40 +0300:

> NAND_DATA_IFACE_CHECK_ONLY is already defined in
> include/linux/mtd/rawnand.h. The intel driver includes
> <linux/mtd/rawnand.h>, so remove the duplicate definition from the intel
> driver.
>=20
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
>  drivers/mtd/nand/raw/intel-nand-controller.c | 2 --
>  1 file changed, 2 deletions(-)
>=20
> diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/n=
and/raw/intel-nand-controller.c
> index 7c1c80dae826..fbf6731420d6 100644
> --- a/drivers/mtd/nand/raw/intel-nand-controller.c
> +++ b/drivers/mtd/nand/raw/intel-nand-controller.c
> @@ -99,8 +99,6 @@
> =20
>  #define HSNAND_ECC_OFFSET	0x008
> =20
> -#define NAND_DATA_IFACE_CHECK_ONLY	-1
> -
>  #define MAX_CS	2
> =20
>  #define USEC_PER_SEC	1000000L

Actually I already received a series which contains a patch doing
exactly that. But thanks anyway :-)

Cheers,
Miqu=C3=A8l