Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3575461rwb; Tue, 20 Sep 2022 01:30:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4sDOGHgK6QedzptuXYWsBVPd34igC+hCFojjtAz3jW4BbdzQoJzciBMS7ufEnLbW/VwBqg X-Received: by 2002:a05:6402:3547:b0:451:3be6:d55b with SMTP id f7-20020a056402354700b004513be6d55bmr18731433edd.57.1663662605091; Tue, 20 Sep 2022 01:30:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663662605; cv=none; d=google.com; s=arc-20160816; b=yFQNk3WI2lzvUEG/+QQzl0Hs/2Ju/546N6zcrxADVGHXWZODSdkFRr2KGYqt1Jy0Mn WYtRj3rAjNgivHu+kcdY3ugbRCMwxyCk0JWMSbgH8y0rR7zrX9nZHsNtOMbIcXTIDnXM Z2OphZUhcO3TsgfsY4kBayiijpTdACz3LtbtHGc4J/IJCHucu3clw9UdLCfIpesUTF0i A7adDaRg7qdMEZbx1usGNQv/8VgHEvugqhqv51E2edZWB2daBPdi1x6LFNzuzy9CL/+P qqTL2TiCRmIGabJSEIMoE3YtjiaoMh3cd3xN8LAtq7bd1zyrcmyAfVvHaRrWsm1ph33t JFbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=If3Ls/Owwi5Io2SdKF5zzGHjWm7fkzHqY9uuV5NqfmI=; b=EtUGEOd1lgPZm4MlhblTn0wJKui/bWxeYltbYsvmbBtY2ltW32wF8HgQgewHjCJU3A QThNwWE47HdOqea/z/jwvVSW5DDUS+XB0oOYq4tLprMwKcqwYTgHlCI7HxrhRP+hDG/h 7wSoiGpD6/30YML1QXAFgyB6wa9h8BTqs2s9QQbq1+NfxuCCmtGz9gcrEYpPbpkeSh2u hXYl/d/5nJWDDit9UKdTzbu3uABj4KxOl5wgBDtRMpG1r0iWUJoUv04IIuwCMUYRiOZe hHsHYrc+DYivKa3Q5LvZ6p94lB84VAklxleQ/9YGcY3YD/nxlDnGQcaBaNNiGBVbqJeC GBDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mTqyeUFo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b63-20020a509f45000000b0045209818732si994515edf.498.2022.09.20.01.29.38; Tue, 20 Sep 2022 01:30:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mTqyeUFo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230202AbiITHsD (ORCPT + 99 others); Tue, 20 Sep 2022 03:48:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230129AbiITHrC (ORCPT ); Tue, 20 Sep 2022 03:47:02 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDB0D11169; Tue, 20 Sep 2022 00:46:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 79C95B80927; Tue, 20 Sep 2022 07:46:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C477C433C1; Tue, 20 Sep 2022 07:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663660016; bh=31LwDD6/RD3aunahOMD2sHT+ewdy1AuM7USPdp3uXHM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mTqyeUFod7XeG7uJJHYdHXiuP62G+G/F1DTcdjdKysdwt9RAOgW5ll7YWf/scejs6 zEpCIB2Dax0KLjpoTMMUb0FUXx+xv+eBdOGN6j/70jM3i3rO8mNhKcf97g9FU9GuPb J2dTXXopZbyl8SN4Y3nm4E4u5v8Vtu32qpOsLZMg= Date: Tue, 20 Sep 2022 09:47:24 +0200 From: Greg Kroah-Hartman To: Akinobu Mita Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-fsdevel@vger.kernel.org, corbet@lwn.net, david@redhat.com, osalvador@suse.de, shuah@kernel.org, Zhao Gongyi , Wei Yongjun , Yicong Yang , "Rafael J. Wysocki" , Alexander Viro , akpm@linux-foundation.org Subject: Re: [PATCH 0/3] fix error when writing negative value to simple attribute files Message-ID: References: <20220919172418.45257-1-akinobu.mita@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220919172418.45257-1-akinobu.mita@gmail.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2022 at 02:24:15AM +0900, Akinobu Mita wrote: > The simple attribute files do not accept a negative value since the > commit 488dac0c9237 ("libfs: fix error cast of negative value in > simple_attr_write()"), but some attribute files want to accept > a negative value. > > Akinobu Mita (3): > libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value > lib/notifier-error-inject: fix error when writing -errno to debugfs > file > debugfs: fix error when writing negative value to atomic_t debugfs > file > > .../fault-injection/fault-injection.rst | 10 +++---- > fs/debugfs/file.c | 28 +++++++++++++++---- > fs/libfs.c | 22 +++++++++++++-- > include/linux/debugfs.h | 19 +++++++++++-- > include/linux/fs.h | 12 ++++++-- > lib/notifier-error-inject.c | 2 +- > 6 files changed, 73 insertions(+), 20 deletions(-) Reviewed-by: Greg Kroah-Hartman