Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1663634940-6515-1-git-send-email-zhaoyang.huang@unisoc.com> <20220920085437.ngyrzgxe2uoi7g4a@techsingularity.net>
In-Reply-To: <20220920085437.ngyrzgxe2uoi7g4a@techsingularity.net>
From:   Zhaoyang Huang <huangzhaoyang@gmail.com>
Date:   Tue, 20 Sep 2022 17:07:33 +0800
Message-ID: <CAGWkznELJWUGBbRb8GE0nRVCtEVSpnLvT+PFnOt-vtyE98CqEw@mail.gmail.com>
Subject: Re: [PATCHv2] mm: check high-order page when free it to pcp
To:     Mel Gorman <mgorman@techsingularity.net>
Cc:     "zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>, Ke Wang <ke.wang@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Sep 20, 2022 at 4:55 PM Mel Gorman <mgorman@techsingularity.net> wrote:
>
> On Tue, Sep 20, 2022 at 08:49:00AM +0800, zhaoyang.huang wrote:
> > From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> >
> > High-order pcp page escaped from checking when both of DEBUG_VM and debug_pagealloc
> > are all disabled if it allocated again from pcp_list without going to global
> > free list, which should be introduced by 44042b4498.
> >
> > fix:44042b4498
> >
> > Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
>
> Why is the order check needed? In this case, I think the comment itself was
> wrong and should be corrected. free_pcp_prepare is called when dealing with
> a PCP page being freed and these days that may order-0 or high-order pages.
> Wieh DEBUG_VM disabled, the pages are checked in by bulkfree_pcp_prepare
> when freeing pages from PCP to the core allocator. Why would just
> high-order pages be checked in free_pcp_prepare and checked again in
> bulkfree_pcp_prepare?
for high-order pcp pages(head page in fact), they might escape from
bulkfree_pcp_prepare if they were allocated from pcp-list
again(pcp->count < high) prior to going to core allocator.
for order-0 pcp pages, they will not be checked at all for the purpose
of reducing overhead.
>
> --
> Mel Gorman
> SUSE Labs