Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5fb488a102d0738ab153bf133439dd64f09d096e.camel@redhat.com>
Subject: Re: [PATCH v2 net-next 03/10] net: dsa: allow the DSA master to be
 seen and changed through rtnetlink
From:   Paolo Abeni <pabeni@redhat.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vladimir Oltean <olteanv@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Colin Foster <colin.foster@in-advantage.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Tobias Waldekranz <tobias@waldekranz.com>,
        Marek =?ISO-8859-1?Q?Beh=FAn?= <kabel@kernel.org>,
        Ansuel Smith <ansuelsmth@gmail.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Alvin =?UTF-8?Q?=C5=A0ipraga?= <alsi@bang-olufsen.dk>,
        Linus Walleij <linus.walleij@linaro.org>,
        Luiz Angelo Daros de Luca <luizluca@gmail.com>,
        Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
        Sean Wang <sean.wang@mediatek.com>,
        David Ahern <dsahern@kernel.org>,
        Stephen Hemminger <stephen@networkplumber.org>
Date:   Tue, 20 Sep 2022 11:24:57 +0200
In-Reply-To: <20220911143554.tq4lf5eqs4novhtn@skbuf>
References: <20220911010706.2137967-1-vladimir.oltean@nxp.com>
         <20220911010706.2137967-4-vladimir.oltean@nxp.com>
         <20220911143554.tq4lf5eqs4novhtn@skbuf>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello,

On Sun, 2022-09-11 at 14:35 +0000, Vladimir Oltean wrote:
> On Sun, Sep 11, 2022 at 04:06:59AM +0300, Vladimir Oltean wrote:
> > +struct rtnl_link_ops dsa_link_ops __read_mostly = {
> > +	.kind			= "dsa",
> > +	.priv_size		= sizeof(struct dsa_port),
> > +	.maxtype		= IFLA_DSA_MAX,
> > +	.policy			= dsa_policy,
> > +	.changelink		= dsa_changelink,
> > +	.get_size		= dsa_get_size,
> > +	.fill_info		= dsa_fill_info,
> > +};
> 
> I forgot to apply Jakub's suggestion to set netns_refund = true.
> On the other hand, I think the patches are otherwise fine, and I
> wouldn't resend them, especially without any feedback. If there is no
> other feedback, can I fix this up through an incremental patch?

Since the delta should be minimal, we have a significant backlog, and
this LGTM, I'm going to apply the series as-is.

Please follow-up with the incremental fix, thanks,

Paolo