Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Sep 2022 10:25:47 +0100
From:   Lee Jones <lee@kernel.org>
To:     Sebastian Urban <surban@surban.net>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: take OF node reference for MFD cell platform device
Message-ID: <YymHG4OmMktrRqof@google.com>
References: <20220917094132.458194-1-surban@surban.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220917094132.458194-1-surban@surban.net>
Precedence: bulk

On Sat, 17 Sep 2022, Sebastian Urban wrote:

> Properly increase OF node reference count when assigning it to a
> platform device created for an MFD cell.
> 
> Signed-off-by: Sebastian Urban <surban@surban.net>
> ---
>  drivers/mfd/mfd-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> index 16d1861e9682..8e57f67719cf 100644
> --- a/drivers/mfd/mfd-core.c
> +++ b/drivers/mfd/mfd-core.c
> @@ -161,7 +161,7 @@ static int mfd_match_of_node_to_dev(struct platform_device *pdev,
>  	of_entry->np = np;
>  	list_add_tail(&of_entry->list, &mfd_of_node_list);
>  
> -	pdev->dev.of_node = np;
> +	pdev->dev.of_node = of_node_get(np);

Doesn't this cause an imbalance?

Or is there already a put somewhere?

>  	pdev->dev.fwnode = &np->fwnode;
>  #endif
>  	return 0;

-- 
Lee Jones [李琼斯]