Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <87e6fdb49d9d76c468712e1b42cbc130273b5635.camel@gmail.com>
Subject: Re: [PATCH] scsi: ufs-bsg: Remove ufs_bsg_get_query_desc_size
 function
From:   Bean Huo <huobean@gmail.com>
To:     Arthur Simchaev <Arthur.Simchaev@wdc.com>, James@vger.kernel.org,
        E.J.Bottomley@vger.kernel.org, jejb@linux.vnet.ibm.com,
        Martin@vger.kernel.org, K.Petersen@vger.kernel.org,
        martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bean@vger.kernel.org, Huo@vger.kernel.org, beanhuo@micron.com
Date:   Tue, 20 Sep 2022 11:38:20 +0200
In-Reply-To: <1655727966-31584-1-git-send-email-Arthur.Simchaev@wdc.com>
References: <1655727966-31584-1-git-send-email-Arthur.Simchaev@wdc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.1-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

Hi Arthur,


On Mon, 2022-06-20 at 15:26 +0300, Arthur Simchaev wrote:
> The bsg driver allows user space to send device management commands.
> As such, it is often used by field application engineers to debug
> various problems,
> and as a test bed for new features as well.
>=20
> Let's not bound ourself to hard coded descriptor sizes, as the new

UFS descriptor size is no longer hardcoded (defined in the driver), the
size of the descriptor is reported by UFS itself, check the latest
kernel.


> Descriptors that supports new features are not defined yet.
>=20
> Signed-off-by: Arthur Simchaev <Arthur.Simchaev@wdc.com>
> ---
> =C2=A0drivers/scsi/ufs/ufs_bsg.c | 28 ++++------------------------
> =C2=A01 file changed, 4 insertions(+), 24 deletions(-)
>=20
> diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c

This UFS driver is in the wrong location, I assume you are using an
older kernel version?

Kind regards,
Bean