Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH net-next v2] net/mlx5e: Ensure macsec_rule is always
 initiailized in macsec_fs_{r,t}x_add_rule()
From:   patchwork-bot+netdevbpf@kernel.org
Message-Id: <166366741421.25964.18299631498168125673.git-patchwork-notify@kernel.org>
Date:   Tue, 20 Sep 2022 09:50:14 +0000
References: <20220911085748.461033-1-nathan@kernel.org>
In-Reply-To: <20220911085748.461033-1-nathan@kernel.org>
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     saeedm@nvidia.com, leon@kernel.org, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        ndesaulniers@google.com, trix@redhat.com, borisp@nvidia.com,
        raeds@nvidia.com, liorna@nvidia.com, netdev@vger.kernel.org,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev, patches@lists.linux.dev
Precedence: bulk

Hello:

This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Sun, 11 Sep 2022 01:57:50 -0700 you wrote:
> Clang warns:
> 
>   drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c:539:6: error: variable 'macsec_rule' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
>           if (err)
>               ^~~
>   drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c:598:9: note: uninitialized use occurs here
>           return macsec_rule;
>                 ^~~~~~~~~~~
>   drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c:539:2: note: remove the 'if' if its condition is always false
>           if (err)
>           ^~~~~~~~
>   drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c:523:38: note: initialize the variable 'macsec_rule' to silence this warning
>           union mlx5e_macsec_rule *macsec_rule;
>                                               ^
>                                               = NULL
>   drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c:1131:6: error: variable 'macsec_rule' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
>           if (err)
>               ^~~
>   drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c:1215:9: note: uninitialized use occurs here
>           return macsec_rule;
>                 ^~~~~~~~~~~
>   drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c:1131:2: note: remove the 'if' if its condition is always false
>           if (err)
>           ^~~~~~~~
>   drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c:1118:38: note: initialize the variable 'macsec_rule' to silence this warning
>           union mlx5e_macsec_rule *macsec_rule;
>                                               ^
>                                               = NULL
>   2 errors generated.
> 
> [...]

Here is the summary with links:
  - [net-next,v2] net/mlx5e: Ensure macsec_rule is always initiailized in macsec_fs_{r,t}x_add_rule()
    https://git.kernel.org/netdev/net-next/c/2e50e9bf328f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html