Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3714846rwb; Tue, 20 Sep 2022 03:47:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4wvx01NqfYiTvtNHfZm/gU+N1X3NKIbFKPc9yzh/6fyeE6iu6LFTnPBF14KTOSGed0ul42 X-Received: by 2002:a17:907:9619:b0:77f:6796:dcb9 with SMTP id gb25-20020a170907961900b0077f6796dcb9mr16308089ejc.7.1663670839230; Tue, 20 Sep 2022 03:47:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663670839; cv=none; d=google.com; s=arc-20160816; b=N4K36bujfSOuyhPbdT/2066OySGoJSunxca/7N4AhVD2UYzfahJ56iUdy6INvZpY+r Y/NznY/9KaYRaP1iYyolee6sP4Rn8jvlaH/bJwVN5RLV+h5TQDc1C03v9nZhXedjOHwA Sy/iSngFDVg0JyTF7c7/Czloxhs4PBJXmv7AEs2pn5Ekv4gAOnFlKtusqc/woxiVn2Kc 1/DvWgivD8R37EZ2zHAr1ywoR6ViH6K5+A7SIbUHBXrNyWx3xvr/IGv5dZDp1/fTr9V4 Fp9whv32LUe2OZbKN4doRykZDkNvPE8R86hoFu5yjLLVnD5Dw86EXEhhSpW7yglN3J6l HiyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=K/52/MbWO4ytqp7RwveMbu4GMVdj0qiv7jLAKdVNpBU=; b=kKnTW/hpJFTUVo3NLUIpkE59fzXTSSQderOf9fnoc6B2/jXduWtPZMQcsS+dvMnJlT u6upH/IjPMlWVOsEYQWUbHzWOMOe4MtpEVzwWjwPCIGtcSoXkXk3dQYA+jdjW12LG/Sg ltW4mtI6wvCPF8odfAnX7NtSuSG+KHzsB+UXgHnuQm9T1aI/N21UPniWVDpMVPV7bqs0 PsbYvV4L1etGFONBIUD5Byl9U/5jzEjnivK7OQl0PmR4R2SXJhqYB3j3bX6Y+EUlohw4 nhQ9Y1CEsdYCSIRrj4VcH5q8nZtDfd8ARYo/fD4XjahN4TeruSMkNXNqwj40VA+1cC6+ +XAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=rock-chips.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bt16-20020a0564020a5000b0044f1473b893si1174385edb.388.2022.09.20.03.46.53; Tue, 20 Sep 2022 03:47:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=rock-chips.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231220AbiITKcN (ORCPT + 99 others); Tue, 20 Sep 2022 06:32:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbiITKbX (ORCPT ); Tue, 20 Sep 2022 06:31:23 -0400 Received: from mail-m11875.qiye.163.com (mail-m11875.qiye.163.com [115.236.118.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E86EA4AD59 for ; Tue, 20 Sep 2022 03:31:21 -0700 (PDT) Received: from localhost.localdomain (unknown [58.22.7.114]) by mail-m11875.qiye.163.com (Hmail) with ESMTPA id 94EDC280BBE; Tue, 20 Sep 2022 18:31:19 +0800 (CST) From: Jianqun Xu To: linus.walleij@linaro.org, heiko@sntech.de, brgl@bgdev.pl, andriy.shevchenko@linux.intel.com Cc: robert.moore@intel.com, robh@kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, lenb@kernel.org, rafael@kernel.org, Jianqun Xu Subject: [PATCH 13/20] gpio/rockchip: disable and put clocks when remove Date: Tue, 20 Sep 2022 18:31:01 +0800 Message-Id: <20220920103108.23074-14-jay.xu@rock-chips.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220920103108.23074-1-jay.xu@rock-chips.com> References: <20220920103108.23074-1-jay.xu@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJSktLSjdXWS1ZQUlXWQ8JGhUIEh9ZQVkZTxhMVh5OTktKT00aGU9KTFUTARMWGhIXJB QOD1lXWRgSC1lBWU5DVUlJVUxVSkpPWVdZFhoPEhUdFFlBWU9LSFVKSktPSEhVSktLVUtZBg++ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6My46Ghw4Vj0fDBwMFwoMLx8d IR4KCTpVSlVKTU1ITU1CQ0NLTk1MVTMWGhIXVREaAlUDDjsJFBgQVhgTEgsIVRgUFkVZV1kSC1lB WU5DVUlJVUxVSkpPWVdZCAFZQUlLSUI3Bg++ X-HM-Tid: 0a835a73c4362eb1kusn94edc280bbe X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Match to the probe, do disable and put the clocks when module to remove. Signed-off-by: Jianqun Xu --- drivers/gpio/gpio-rockchip.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index 511e93a6a429..1a800f972594 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -757,7 +757,10 @@ static int rockchip_gpio_remove(struct platform_device *pdev) { struct rockchip_pin_bank *bank = platform_get_drvdata(pdev); + clk_put(bank->clk); + clk_put(bank->db_clk); clk_disable_unprepare(bank->clk); + clk_disable_unprepare(bank->db_clk); gpiochip_remove(&bank->gpio_chip); return 0; -- 2.25.1