Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bb3fa609-858f-ab16-95b4-06fd43ec6129@kernel.org>
Date:   Tue, 20 Sep 2022 12:58:04 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v4 10/10] tty: serial: use uart_port_tx_limited()
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial <linux-serial@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Florian Fainelli <f.fainelli@gmail.com>,
        bcm-kernel-feedback-list@broadcom.com,
        =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali@kernel.org>,
        Kevin Cernekee <cernekee@gmail.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        Patrice Chotard <patrice.chotard@foss.st.com>,
        linux-riscv@lists.infradead.org
References: <20220920052049.20507-1-jslaby@suse.cz>
 <20220920075844.29360-1-jslaby@suse.cz>
 <f2653c92-1769-fc7c-8ad8-abf34affef6b@linux.intel.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <f2653c92-1769-fc7c-8ad8-abf34affef6b@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 20. 09. 22, 11:19, Ilpo Järvinen wrote:
> One improvement suggestion below.
> 
>> diff --git a/drivers/tty/serial/altera_jtaguart.c b/drivers/tty/serial/altera_jtaguart.c
>> index 23f339757894..f224f5141726 100644
>> --- a/drivers/tty/serial/altera_jtaguart.c
>> +++ b/drivers/tty/serial/altera_jtaguart.c
>> @@ -137,39 +137,17 @@ static void altera_jtaguart_rx_chars(struct altera_jtaguart *pp)
>>   static void altera_jtaguart_tx_chars(struct altera_jtaguart *pp)
...
>> +	space = readl(port->membase + ALTERA_JTAGUART_CONTROL_REG);
>> +	space &= ALTERA_JTAGUART_CONTROL_WSPACE_MSK;
>> +	space >>= ALTERA_JTAGUART_CONTROL_WSPACE_OFF;
> 
> This is FIELD_GET(ALTERA_JTAGUART_CONTROL_WSPACE_MSK, ...) & then allows
> killing ALTERA_JTAGUART_CONTROL_WSPACE_OFF. I'd probably do it in a
> separate patch though.

Right. Prepared for v5.

thanks,
-- 
js
suse labs