Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3807607rwb; Tue, 20 Sep 2022 05:10:12 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5UTwOfwUif67gWAbzRHk5xiEEX06siKr3xFssOFOX8k9an48we6tSRQ9WEFjvNrU+dlgWk X-Received: by 2002:a17:907:60d3:b0:77e:5e9b:8ec with SMTP id hv19-20020a17090760d300b0077e5e9b08ecmr16579141ejc.640.1663675811695; Tue, 20 Sep 2022 05:10:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663675811; cv=none; d=google.com; s=arc-20160816; b=yUpRjtn9TnqnbLO1i7O2JcjvaCQqnPOPGcLZ7LjCUeZbcyS/6jW0O6Rxr+IBtlg8dh 8wtKV7R1JQFn18ijuVhCiTn9C+U2u+/kgugRvNNCW/WNfbd+U97uEo9vunYcGFyKgUUc kGjyD67qZpsyg6QvPOu87EkqsBL3Ka8t2wNkRR2WDgbbSkb6Oju85GvLkynQuYvPzAeK SjvqynbAPRzDi2qLR97WYQnLPmQnjWxck0Y+FsnMCX+cMSmQQy7EEbF2RY2ijzdFTEna k0KL3AdXdarb1xT0laCL3VoVTxUAg3Wr8HjdagMI/4D/Kb+O7SKWN1fep71gwMDX77yF RgDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=kj+xKWpvHIZPoxKCGMG5/65nS3AdN5h8wz2helVY+es=; b=Wv5gB1dCdPI/o3/UPb3L8dAHN/u/H6SktKxOynIoFaP+wS4J56gd4+PBrZx8ZlPWhb ku5VIRyQR+FOxb/YJuVNPhRCxLA0fRSltLt+JnO9+5W4I3Q9ITavnx1PJSZiruE8CRoV rWKbbtUZr75j8CO1zuWpQZr8KZTtky4BQnkWEaaadtVi+lX3M85y/zrmVmDl0ICi4csd ycDpNeDPwSo/UMxxAOTvGL5DCk8iiVPYsa8eQ8ae08EoaZRiknEoaoJMIFvUvtiOI69j 7ONxG4b4oAzB5CDWeSaaDRT5esrr8AG4ATSIdCYXqPfM8qgm38E74O13RoJ6NLXs2W6S Pz3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hz5-20020a1709072ce500b0078185d33874si1227697ejc.304.2022.09.20.05.09.45; Tue, 20 Sep 2022 05:10:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229978AbiITLoS (ORCPT + 99 others); Tue, 20 Sep 2022 07:44:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230184AbiITLn6 (ORCPT ); Tue, 20 Sep 2022 07:43:58 -0400 Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [IPv6:2a01:37:1000::53df:5f64:0]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6110A74BBB; Tue, 20 Sep 2022 04:43:37 -0700 (PDT) Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1" (verified OK)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id B93893000244E; Tue, 20 Sep 2022 13:43:31 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id ADB6D2D939; Tue, 20 Sep 2022 13:43:31 +0200 (CEST) Date: Tue, 20 Sep 2022 13:43:31 +0200 From: Lukas Wunner To: Lino Sanfilippo Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, u.kleine-koenig@pengutronix.de, linux@armlinux.org.uk, richard.genoud@gmail.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, p.rosenberger@kunbus.com Subject: Re: Move RS485 implementation from drivers to serial core (v4 RESEND) Message-ID: <20220920114331.GA26352@wunner.de> References: <20220410104642.32195-1-LinoSanfilippo@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220410104642.32195-1-LinoSanfilippo@gmx.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 10, 2022 at 12:46:33PM +0200, Lino Sanfilippo wrote: > This patch series is an attempt to simplify rs485 implementation in drivers > by moving the following tasks out of the drivers into the serial core: > > - ensure sane RTS settings: in case of an invalid configuration (both RTS > after send and RTS on send set or both unset) enable RTS on send and > disable RTS after send [...] > Redundant code has been removed from the following drivers for now: > > - atmel > - fsl_lpuart > - amba > - imx > - max310x > - omap-serial > - sc16is7xx > - stm32-usart It looks like there's more of this cruft left at least in serial8250_em485_config()... Thanks, Lukas