Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Pandey, Radhey Shyam" <radhey.shyam.pandey@amd.com>
To:     Vinod Koul <vkoul@kernel.org>,
        "Gaddam, Sarath Babu Naidu" <sarath.babu.naidu.gaddam@amd.com>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "lars@metafoo.de" <lars@metafoo.de>,
        "adrianml@alumnos.upm.es" <adrianml@alumnos.upm.es>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Simek, Michal" <michal.simek@amd.com>,
        "Sarangi, Anirudha" <anirudha.sarangi@amd.com>,
        "Katakam, Harini" <harini.katakam@amd.com>,
        "git@xilinx.com" <git@xilinx.com>, "git (AMD-Xilinx)" <git@amd.com>
Subject: RE: [RFC V3 PATCH 0/8] Xilinx DMA enhancements and optimization
Thread-Topic: [RFC V3 PATCH 0/8] Xilinx DMA enhancements and optimization
Thread-Index: AQHYzLUokPyXdBQ+zkGuk0IkXRyZp63oLoSAgAABReA=
Date:   Tue, 20 Sep 2022 12:00:02 +0000
Message-ID: <MN0PR12MB5953774B25AB9CA40A8BB43EB74C9@MN0PR12MB5953.namprd12.prod.outlook.com>
References: <20220920055119.12634-1-sarath.babu.naidu.gaddam@amd.com>
 <YymjofmCECa3iF20@matsya>
In-Reply-To: <YymjofmCECa3iF20@matsya>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tCwztYtqFXdhozUC5uTguGe4BNhv8pGA+diiIzlK+gxLwQOyGMwgTiYOB/0M?=
 =?us-ascii?Q?TKxakstrj1gH25Fe14nerm2/OVx/s4ekdseBidDEQcnns3lSUwQQh606BYsh?=
 =?us-ascii?Q?iwyuAridNzRX0LpyHIJa98VQe8a1p+8Wa4/X6TsNKmhOjT/f3dkv0C2Xypd7?=
 =?us-ascii?Q?pxda0WQ7RsTwZh3uVhbgkgJeYR1KW9yGevXbPwyFjbTZvvY7K/hA6DQmQt+m?=
 =?us-ascii?Q?sE3qdSBHqNmoB1uskMG+wawv+8NF5KRHPeJLpfBJSyjnxwARW/BRQGRF2GYg?=
 =?us-ascii?Q?t68Dd11b0hq4DD9yK77xH8KCm8JUz0AJtG/hHX2MqQ2yT0xLABezZqV2OCro?=
 =?us-ascii?Q?DiJSz5WbkCZn5/uBeSTLFeONe8ZFwYtIF3fdgdCpkEBt3FSWT55Kbm732GRi?=
 =?us-ascii?Q?NhUtAFdhpdFqSywJHlg8IyUVBxd48pLWm6R8n6xS7yqpdWrQy+IqnOd4Texh?=
 =?us-ascii?Q?0AytMBK0Vzt7VaybEnI1Uwl+TAFiwv3CIU8Qqvy7StvVR111IqauX1CiA3M5?=
 =?us-ascii?Q?djzscmCy/mv3+8AUGt/rlVzTcCmxFrsDOkPiK/+9EqIjjQ3VNPG0zxveiTqn?=
 =?us-ascii?Q?NN8IxDPgpti7tLoHVBiiWuxRehd/3RBXSGlLLRVtDC+nvxiy0AqYQNW9fItX?=
 =?us-ascii?Q?MF9Rx/rs/m8tMpwSJ2zYvrK5zk+aSo2EoF8MPdQalaxqJhjr56Smme0u03dX?=
 =?us-ascii?Q?8DznO39o0rkdWM8qXP/eJT56rjDW4qS5Zmny5SvPzsefHAEclLQY66tklUeU?=
 =?us-ascii?Q?NBSsAa8ybywiAc4KvbXrt3oK4nIL/PfCJKag7H546eCCOByILQ23hb5r5w/K?=
 =?us-ascii?Q?U9Cd8vi8I145xR2op/w6JAskb5Q1MHUlTJGIEivBHDwTzwOxY0FtKWteXOCI?=
 =?us-ascii?Q?+LBV8T+QztCRjCq6wcQbzfU2JzitzqpVs0T1/F/tSzjiq268QfNZNfvCAwYG?=
 =?us-ascii?Q?l44NvCdu37/wQb3xX2dbS/q6MYCR3D87JJ+1tRg01dj/uUI1DbfbcQe+N2Z5?=
 =?us-ascii?Q?FG1Z6lAM0VoRndh/v/XCbW+11xut3dbNQn1WRIj5dmu6MvSa5BKJF0QqP9BT?=
 =?us-ascii?Q?/yUZ9L/MYZI/EZt+6qx4EigxIhCUdJlR3DQX7RZJUFPehlu/laGBDzHIggmT?=
 =?us-ascii?Q?HI6Tq4JDYZvoxSS6aRBE6HmD+lEb0C1s5HhSiDT9FThn3BCH+DOl7p5NmRqj?=
 =?us-ascii?Q?zDpMPr5/bQZhPh0TuhmmvTUac5LDGSArXo3t3Re9yOfGInklralr02eGbx17?=
 =?us-ascii?Q?mLVjmMNYrmsiaf7eFDIsJUtx9Q6s5xM8Y3bizbbrDzhvJUgnV9HAycNKGbG/?=
 =?us-ascii?Q?a1rVrBoMTsvtB9HCW9iW43Afj4+CYczLoyOvVCrjCFkj7qLLmiyfr4ZWHVbu?=
 =?us-ascii?Q?pM9PiJ1lpn8jLhvPkr5ou4c/wTFD/EMHQULyp7dKs5ywXl2k8nIzafgsgTBO?=
 =?us-ascii?Q?xwOxqlmWZwWG0Zo8diACk0iHN8gW9rMCmBGgmlCLv92f7tCjJs1CPpFHOLLM?=
 =?us-ascii?Q?q/7JOJnpuQAHVhst57+Z7AScnfksYPyBWLr2sMgccQM/Dxq5ruBNYaF3+A0A?=
 =?us-ascii?Q?+fTyHhnLIpGROdXJscZFDqtv454XaijTIvd3dL6z30uNIByJoeDywnO3AUy2?=
 =?us-ascii?Q?QSfaaACTGIZJhWCN+agsvjM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5953.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9031210-8a81-489f-8ca9-08da9affa6af
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2022 12:00:03.0050
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AGMpkiVTmIgPxx7vzlKl++YUub2Nz35xZX+XVsG8JiRUasveHh/w7nAAhwUgEPF1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7294
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Vinod Koul <vkoul@kernel.org>
> Sent: Tuesday, September 20, 2022 4:57 PM
> To: Gaddam, Sarath Babu Naidu <sarath.babu.naidu.gaddam@amd.com>
> Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> lars@metafoo.de; adrianml@alumnos.upm.es; dmaengine@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; Simek, Michal <michal.simek@amd.com>; Pandey,
> Radhey Shyam <radhey.shyam.pandey@amd.com>; Sarangi, Anirudha
> <anirudha.sarangi@amd.com>; Katakam, Harini
> <harini.katakam@amd.com>; git@xilinx.com; git (AMD-Xilinx)
> <git@amd.com>
> Subject: Re: [RFC V3 PATCH 0/8] Xilinx DMA enhancements and optimization
>=20
> On 20-09-22, 11:21, Sarath Babu Naidu Gaddam wrote:
> > Some background about the patch series: Xilinx Axi Ethernet device
> > driver
> > (xilinx_axienet_main.c) currently has axi-dma code inside it. The goal
> > is to refactor axiethernet driver and use existing AXI DMA driver
> > using DMAEngine API.
> >
> > This patchset does feature addition and optimization to support axidma
> > integration with axiethernet network driver. Once axidma version is
> > accepted mcdma specific changes will be added in followup version.
>=20
> why is this tagged RFC? Is it not ready for merge?

To recap - In v3, the new addition is "[PATCH 8/8] dmaengine:=20
xilinx_dma: Add device_config support" along with addressing=20
RFC v2 comment.=20

8/8 is initial proposal on how to implement coalesce feature in
dmaengine driver to support ethernet usecases. Thought was
that it's better to have this idea reviewed as RFC before=20
extending the logic for other IP variants and spin sanity test
all usecases.=20

Fallback option is to split this series and send patches which are
already reviewed in RFC v2 as PATCH and only 8/8 (which need=20
more discussion/framework extension) as RFC?
Let me know your thoughts.=20

Thanks,
Radhey
>=20
> >
> > Changes for V2:
> > - Use metadata API[1] for passing metadata from dma to netdev client.
> > - Read irq-delay from DT.
> > - Remove desc_callback_valid check.
> > - Addressed RFC v1 comments[2].
> > - Minor code refactoring.
> >
> > Changes for V3:
> > - Add device_config support for passing any dma client data.
> > - Address RFC v2 comments.
> >     - remove hardcoding for axidma_tx_segment.
> >     - Below review comment is in pipeline. We are facing a race issue w=
hen
> >       addressing it. we will fix it in the next version.
> >       "chan->idle =3D true; in xilinx_dma_irq_handler() needs to be gat=
ed on
> >        the active_list being empty".
> >
> > Comments, suggestions are very welcome
> >
> > Radhey Shyam Pandey (7):
> >   dt-bindings: dmaengine: xilinx_dma: Add xlnx,axistream-connected
> >     property
> >   dt-bindings: dmaengine: xilinx_dma: Add xlnx,irq-delay property
> >   dmaengine: xilinx_dma: Pass AXI4-Stream control words to dma client
> >   dmaengine: xilinx_dma: Increase AXI DMA transaction segment count
> >   dmaengine: xilinx_dma: Freeup active list based on descriptor
> >     completion bit
> >   dmaengine: xilinx_dma: Use tasklet_hi_schedule for timing critical
> >     usecase
> >   dmaengine: xilinx_dma: Program interrupt delay timeout
> >
> > Sarath Babu Naidu Gaddam (1):
> >   dmaengine: xilinx_dma: Add device_config support
> >
> >  .../bindings/dma/xilinx/xilinx_dma.txt        |   4 +
> >  drivers/dma/xilinx/xilinx_dma.c               | 107 ++++++++++++++++--
> >  include/linux/dma/xilinx_dma.h                |  16 +++
> >  3 files changed, 115 insertions(+), 12 deletions(-)
> >
> > --
> > 2.25.1
>=20
> --
> ~Vinod