Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] mm/secretmem: remove reduntant return value
To:     David Hildenbrand <david@redhat.com>, <akpm@linux-foundation.org>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
References: <20220920012205.246217-1-xiujianfeng@huawei.com>
 <3196b824-bcee-0c44-bfd3-f6cd8a1e6719@redhat.com>
From:   xiujianfeng <xiujianfeng@huawei.com>
Message-ID: <c4e99ea3-302d-b173-27f1-92c38ddaca8c@huawei.com>
Date:   Tue, 20 Sep 2022 20:35:30 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <3196b824-bcee-0c44-bfd3-f6cd8a1e6719@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

在 2022/9/20 20:10, David Hildenbrand 写道:
> On 20.09.22 03:22, Xiu Jianfeng wrote:
>> The return value @ret is always 0, so remove it and return 0 directly.
>>
>> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
>> ---
>>   mm/secretmem.c | 6 ++----
>>   1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/mm/secretmem.c b/mm/secretmem.c
>> index 6a44efb673b2..04c3ac9448a1 100644
>> --- a/mm/secretmem.c
>> +++ b/mm/secretmem.c
>> @@ -278,10 +278,8 @@ static struct file_system_type secretmem_fs = {
>>   static int __init secretmem_init(void)
>>   {
>> -    int ret = 0;
>> -
>>       if (!secretmem_enable)
>> -        return ret;
>> +        return 0;
>>       secretmem_mnt = kern_mount(&secretmem_fs);
>>       if (IS_ERR(secretmem_mnt))
> 
> On top of which tree is that?
> 
> 6.0-rc6 has here:
> 
> if (IS_ERR(secretmem_mnt))
>      ret = PTR_ERR(secretmem_mnt);
> 
Sorry, it's on linux-next tree, I should have used [PATCH -next]:)