Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3914504rwb; Tue, 20 Sep 2022 06:32:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4z2tXLN08n0I6DYGT9HCBymVN76cOdgAZ6MucOGahfIM3m/6bh7SFVJZ5nfM2eO90Pmkt/ X-Received: by 2002:a05:6a00:1a07:b0:541:6060:705d with SMTP id g7-20020a056a001a0700b005416060705dmr23966874pfv.61.1663680737760; Tue, 20 Sep 2022 06:32:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663680737; cv=none; d=google.com; s=arc-20160816; b=Kqe0FQJTkbmUq5x7+kMqBHGTe1Tcd2X45q4/xPG4DDoj6PcvFHfGtF4i5PXeW2EGbu L1HJFj5ML95CqqmyMcqdaM7iKbVnP2/VcaE/yAh6uOz7Pm/PuPmj6/9/jjg6posUjbaC HZ9l0AObqF8MONUw+qQxygiBMeKUmmvnfT/girvccGT0200+sPkm6cFUQWdWgKrQrVQD UxxDPyAb9jL9JHoHym/jMUKIDlBGeFQYRHFdem3irip5gLo6AfPFC6j6ggBF+frpP1Ww yhqUSsa7hMHLFa6ogIti5LWN0YCmce+isV0diCUhirLk5UKlswaid8FR6CGC6iVYzQ2B 4ZJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Elnu7bpANXPrM1PE7lHq91CUKuXWmTGmVUjcxfcQtwA=; b=XbFjLM1JsWARCSaiWSnV5XETDhdFFcvhvhEM6pKu4iyoweUrY0AcnQKt9EDlP2Lq9e FG0z2n7s6CVa52XecDq+x6OPBnlogv36TzeSxT3QPLXxnVpoPVod0V7Mvkpg1H3Htjc4 5YSaaforOm4XPmMZQeKxZqVBqo1t8AYQhhWduBZK9UKVlL4Y6Yow5cS4oKcXVBI5/mFO W/kyFfz3XrT+MMVK9f54OZ66cuRteghJKRSBczttzNq39BATqFmaUxN1775+cw9JBXk4 306s9a1ZJrefmhZ/FQx5Bi9FkO+i4JW/U45HbghUbTMUu9jdxOkZgTRNJK1Dnx6aZuKl t5OQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OBveevzx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h17-20020a056a00231100b00536ee478380si2064889pfh.7.2022.09.20.06.32.04; Tue, 20 Sep 2022 06:32:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OBveevzx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230489AbiITMXT (ORCPT + 99 others); Tue, 20 Sep 2022 08:23:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230466AbiITMXS (ORCPT ); Tue, 20 Sep 2022 08:23:18 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 556B373901 for ; Tue, 20 Sep 2022 05:23:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663676596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Elnu7bpANXPrM1PE7lHq91CUKuXWmTGmVUjcxfcQtwA=; b=OBveevzxjxixgRn21cJSilTOtBa89PXfZWy3vv5rkETQXOA2Gjck0m/pk2of/3Bhm9PftR qwI8mdsM8OGJGs6W68o1x8A+gzsG30I9NXHdvzKk2hWl8zafzVb0DugYiyj2cChm+ZF/3Q EXCD7GGYmT3dXrP/D17axlJr/Imgbf0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-632-w7ie62AuMA2p2FaXb2QrxA-1; Tue, 20 Sep 2022 08:23:09 -0400 X-MC-Unique: w7ie62AuMA2p2FaXb2QrxA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C4924862FE0; Tue, 20 Sep 2022 12:23:08 +0000 (UTC) Received: from t480s.redhat.com (unknown [10.39.195.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 016C9C15BBC; Tue, 20 Sep 2022 12:23:03 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, David Hildenbrand , Linus Torvalds , Andrew Morton , Ingo Molnar , David Laight , Jonathan Corbet , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , Baoquan He , Vivek Goyal , Dave Young , Jani Nikula , Michael Ellerman , Nicholas Piggin , Christophe Leroy Subject: [PATCH v1 0/3] coding-style.rst: document BUG() and WARN() rules Date: Tue, 20 Sep 2022 14:22:59 +0200 Message-Id: <20220920122302.99195-1-david@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As it seems to be rather unclear if/when to use BUG(), BUG_ON(), VM_BUG_ON(), WARN_ON_ONCE(), ... let's try to document the result of a recent discussion. Details can be found in patch #1. RFC -> v1: * "coding-style.rst: document BUG() and WARN() rules ("do not crash the kernel")" -> Rephrase/extend according to John -> Add some details regarding the use of panic() * powerpc/prom_init: drop PROM_BUG() -> Added * "checkpatch: warn on usage of VM_BUG_ON() and other BUG variants" -> Warn on more variants Cc: Linus Torvalds Cc: Andrew Morton Cc: Ingo Molnar Cc: David Laight Cc: Jonathan Corbet Cc: Andy Whitcroft Cc: Joe Perches Cc: Dwaipayan Ray Cc: Lukas Bulwahn Cc: Baoquan He Cc: Vivek Goyal Cc: Dave Young Cc: Jani Nikula Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy David Hildenbrand (3): coding-style.rst: document BUG() and WARN() rules ("do not crash the kernel") powerpc/prom_init: drop PROM_BUG() checkpatch: warn on usage of VM_BUG_ON() and other BUG variants Documentation/process/coding-style.rst | 61 ++++++++++++++++++++++++++ arch/powerpc/kernel/prom_init.c | 6 --- scripts/checkpatch.pl | 6 +-- 3 files changed, 64 insertions(+), 9 deletions(-) -- 2.37.3