Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Sep 2022 15:25:20 +0200
From:   Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To:     Rafael Mendonca <rafaelmendsr@gmail.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: ov5648: Free V4L2 fwnode data on unbind
Message-ID: <Yym/QDURAtn1LX8i@aptenodytes>
References: <20220919023247.731106-1-rafaelmendsr@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="9uSi25hGhxag/Hrg"
Content-Disposition: inline
In-Reply-To: <20220919023247.731106-1-rafaelmendsr@gmail.com>
Precedence: bulk


--9uSi25hGhxag/Hrg
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Rafael,

On Sun 18 Sep 22, 23:32, Rafael Mendonca wrote:
> The V4L2 fwnode data structure doesn't get freed on unbind, which leads to
> a memleak.

Thanks for this patch, good catch!

I agree with Jacopo, you shouldn't add a newline before the call.
Feel free to send a v2 with that fixed and include my:

Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Cheers,

Paul

> Fixes: e43ccb0a045f ("media: i2c: Add support for the OV5648 image sensor=
")
> Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
> ---
>  drivers/media/i2c/ov5648.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/media/i2c/ov5648.c b/drivers/media/i2c/ov5648.c
> index dfcd33e9ee13..95850f06112b 100644
> --- a/drivers/media/i2c/ov5648.c
> +++ b/drivers/media/i2c/ov5648.c
> @@ -2598,6 +2598,8 @@ static int ov5648_remove(struct i2c_client *client)
>  	mutex_destroy(&sensor->mutex);
>  	media_entity_cleanup(&subdev->entity);
> =20
> +	v4l2_fwnode_endpoint_free(&sensor->endpoint);
> +
>  	return 0;
>  }
> =20
> --=20
> 2.34.1
>=20

--=20
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

--9uSi25hGhxag/Hrg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmMpv0AACgkQ3cLmz3+f
v9FR8Qf/YtP4XukNSQNQ6xjgkO5Nl4UDlg/p3v3HkQhsgpDasIQUrFhSgjwcJ0HI
sA07XaEtElbrbAwbLyqhuxJc/sSYXlhSzaEp7YMm6NwjPmAVXY1cYmU0qRXcupEE
KIZWjdVA+O+FR2DTmHLxIb2e4nRKSw5Et1er8kVdxJ58Zy57I+clIidNJFJYh2c1
P5iGPsnYLSIvbHdZhgvocfE7lrs34o+fZGZfSLtGxPpZzRABVVwv7exPL4feC64x
n6s7iNGxMBH3SHu0JJCQ+yDA6El20sQxbUpoMNawI/MWDjn6G7a4HKpCx8qPxldP
JyaATLXCdPuaFQPZ9ot04/lYksARqA==
=x+Bz
-----END PGP SIGNATURE-----

--9uSi25hGhxag/Hrg--