Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3ed55b0d-6c14-79a1-b4c1-5764c667d195@collabora.com>
Date:   Tue, 20 Sep 2022 15:22:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH 1/2] dt-bindings: net: mediatek-dwmac: add support for
 mt8188
Content-Language: en-US
To:     Jianguo Zhang <jianguo.zhang@mediatek.com>,
        "David S . Miller" <davem@davemloft.net>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Biao Huang <biao.huang@mediatek.com>, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
References: <20220920083617.4177-1-jianguo.zhang@mediatek.com>
 <20220920083617.4177-2-jianguo.zhang@mediatek.com>
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <20220920083617.4177-2-jianguo.zhang@mediatek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Il 20/09/22 10:36, Jianguo Zhang ha scritto:
> Add binding document for the ethernet on mt8188
> 
> Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
> ---
>   .../devicetree/bindings/net/mediatek-dwmac.yaml        | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> index 61b2fb9e141b..eaf7e8d53432 100644
> --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> @@ -20,6 +20,7 @@ select:
>           enum:
>             - mediatek,mt2712-gmac

Please keep the list ordered by name. MT8188 goes before 8195.

>             - mediatek,mt8195-gmac
> +          - mediatek,mt8188-gmac
>     required:
>       - compatible
>   
> @@ -37,6 +38,11 @@ properties:
>             - enum:
>                 - mediatek,mt8195-gmac
>             - const: snps,dwmac-5.10a
> +      - items:
> +          - enum:
> +              - mediatek,mt8188-gmac
> +          - const: mediatek,mt8195-gmac
> +          - const: snps,dwmac-5.10a
>   
>     clocks:
>       minItems: 5
> @@ -74,7 +80,7 @@ properties:
>         or will round down. Range 0~31*170.
>         For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550,
>         or will round down. Range 0~31*550.
> -      For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290,
> +      For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290,

For MT8188/MT8195

>         or will round down. Range 0~31*290.
>   
>     mediatek,rx-delay-ps:
> @@ -84,7 +90,7 @@ properties:
>         or will round down. Range 0~31*170.
>         For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550,
>         or will round down. Range 0~31*550.
> -      For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple
> +      For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value need to be a multiple

For MT8188/MT8195

>         of 290, or will round down. Range 0~31*290.
>   
>     mediatek,rmii-rxc: