Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Sep 2022 10:58:30 -0300
From:   Rafael Mendonca <rafaelmendsr@gmail.com>
To:     Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: ov5648: Free V4L2 fwnode data on unbind
Message-ID: <YynHBkbTw6bTgYNq@macondo>
References: <20220919023247.731106-1-rafaelmendsr@gmail.com>
 <Yym/QDURAtn1LX8i@aptenodytes>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yym/QDURAtn1LX8i@aptenodytes>
Precedence: bulk

On Tue, Sep 20, 2022 at 03:25:20PM +0200, Paul Kocialkowski wrote:
> Hi Rafael,
> 
> On Sun 18 Sep 22, 23:32, Rafael Mendonca wrote:
> > The V4L2 fwnode data structure doesn't get freed on unbind, which leads to
> > a memleak.
> 
> Thanks for this patch, good catch!
> 
> I agree with Jacopo, you shouldn't add a newline before the call.

Thanks for the review, I'll send a v2. As the code for the ov5648 is
similar to the ov8865, and in the 8865 there is this blank line before
the v4l2_fwnode_endpoint_free() call, I thought it might be good to keep
the same style here, that's why this empty line ended up appearing here.

> Feel free to send a v2 with that fixed and include my:
> 
> Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> 
> Cheers,
> 
> Paul
> 
> > Fixes: e43ccb0a045f ("media: i2c: Add support for the OV5648 image sensor")
> > Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
> > ---
> >  drivers/media/i2c/ov5648.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/media/i2c/ov5648.c b/drivers/media/i2c/ov5648.c
> > index dfcd33e9ee13..95850f06112b 100644
> > --- a/drivers/media/i2c/ov5648.c
> > +++ b/drivers/media/i2c/ov5648.c
> > @@ -2598,6 +2598,8 @@ static int ov5648_remove(struct i2c_client *client)
> >  	mutex_destroy(&sensor->mutex);
> >  	media_entity_cleanup(&subdev->entity);
> >  
> > +	v4l2_fwnode_endpoint_free(&sensor->endpoint);
> > +
> >  	return 0;
> >  }
> >  
> > -- 
> > 2.34.1
> > 
> 
> -- 
> Paul Kocialkowski, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com