Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Sep 2022 16:07:43 +0200
From:   Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To:     Rafael Mendonca <rafaelmendsr@gmail.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: ov5648: Free V4L2 fwnode data on unbind
Message-ID: <YynJL5834XNvshyT@aptenodytes>
References: <20220919023247.731106-1-rafaelmendsr@gmail.com>
 <Yym/QDURAtn1LX8i@aptenodytes>
 <YynHBkbTw6bTgYNq@macondo>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="zaB1nv5BiLMNa+jQ"
Content-Disposition: inline
In-Reply-To: <YynHBkbTw6bTgYNq@macondo>
Precedence: bulk


--zaB1nv5BiLMNa+jQ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Rafael,

On Tue 20 Sep 22, 10:58, Rafael Mendonca wrote:
> On Tue, Sep 20, 2022 at 03:25:20PM +0200, Paul Kocialkowski wrote:
> > Hi Rafael,
> >=20
> > On Sun 18 Sep 22, 23:32, Rafael Mendonca wrote:
> > > The V4L2 fwnode data structure doesn't get freed on unbind, which lea=
ds to
> > > a memleak.
> >=20
> > Thanks for this patch, good catch!
> >=20
> > I agree with Jacopo, you shouldn't add a newline before the call.
>=20
> Thanks for the review, I'll send a v2. As the code for the ov5648 is
> similar to the ov8865, and in the 8865 there is this blank line before
> the v4l2_fwnode_endpoint_free() call, I thought it might be good to keep
> the same style here, that's why this empty line ended up appearing here.

Understood! I'd be tempted to make a cosmetic fix for 8865 but will probably
wait to group it with functional changes.

Cheers,

Paul

> > Feel free to send a v2 with that fixed and include my:
> >=20
> > Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> >=20
> > Cheers,
> >=20
> > Paul
> >=20
> > > Fixes: e43ccb0a045f ("media: i2c: Add support for the OV5648 image se=
nsor")
> > > Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
> > > ---
> > >  drivers/media/i2c/ov5648.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >=20
> > > diff --git a/drivers/media/i2c/ov5648.c b/drivers/media/i2c/ov5648.c
> > > index dfcd33e9ee13..95850f06112b 100644
> > > --- a/drivers/media/i2c/ov5648.c
> > > +++ b/drivers/media/i2c/ov5648.c
> > > @@ -2598,6 +2598,8 @@ static int ov5648_remove(struct i2c_client *cli=
ent)
> > >  	mutex_destroy(&sensor->mutex);
> > >  	media_entity_cleanup(&subdev->entity);
> > > =20
> > > +	v4l2_fwnode_endpoint_free(&sensor->endpoint);
> > > +
> > >  	return 0;
> > >  }
> > > =20
> > > --=20
> > > 2.34.1
> > >=20
> >=20
> > --=20
> > Paul Kocialkowski, Bootlin
> > Embedded Linux and kernel engineering
> > https://bootlin.com
>=20
>=20

--=20
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

--zaB1nv5BiLMNa+jQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmMpyS8ACgkQ3cLmz3+f
v9F2rgf9GWJRbsfTRwscJGXsW2i6pIThfLIysGiwYV+1lqVNbTCzLA4z1XckxHrw
06zL/v+ZIq0KROZXE5Z3DTOBhnfXd0xVnfrVlY145dgRxFsg44icsjHtf/NFcS/b
F5vj+kGhuddzFi7Vdg9HtuZFexzZBQCZ3of2+1E3bjsuzqt000DEeoVHLnuqg4vP
UWsp/LrqgM1197fw+ylhJpE4RJWQSAreMywhvaabfJQO28KkqDMTJQI/AvOeU/6h
eAzIIG43OiNtIjedkJWb3dS6ZYWgUeAclKQcx5JG24msZub0UZyKKoZa+ycTMb5/
jvFgrKg6TT0oH4W2ftvPLQ5xSxCFUQ==
=jW0C
-----END PGP SIGNATURE-----

--zaB1nv5BiLMNa+jQ--