Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4022862rwb; Tue, 20 Sep 2022 07:50:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6kylQGNT4oyoZwRXs3j7JftKWpmf5J9S9EzdNY3orFD+JzzHOhTtP6jrvufqaLvhkNv/EA X-Received: by 2002:a17:902:e886:b0:178:28d1:4a17 with SMTP id w6-20020a170902e88600b0017828d14a17mr94462plg.63.1663685418784; Tue, 20 Sep 2022 07:50:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663685418; cv=none; d=google.com; s=arc-20160816; b=XyIf0HkK2yOBS8ixHobBabl+e+j/WzBXN9gA7sh4UV8M/8t2dACcII0JD5TxKnk9ui p9TFGLn7iS0WBBpSQvQRJ9QEmrnZt1BS5Sh5284eBX2JOqHxl8lu2U8TagCT8dMKIZ/I 23o+KvEUnwtsT+hoADaG3GyXPhfFWO4FwWodOvah3Pc1JhSLaS7b9UCEF2AVdSkPt2o1 jyaC87eYED8pGt0PM2LDtjplAyuQ9AXLdOOxUgia7+n8rfkpHOudZJymiuyLhLe+f2B/ Bo3mGM5k1R/cA9uj3ZqeHqLN0OR3kHZHPgMj/CWjjWSvVYl+dvO/YTbKEOLyFvekxZ+T uRhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=I74h6Nr+i8FTSqMM2icXg4l/Z8d01teWye2vzkJV1Yo=; b=viGBBiU0gH+6koxZFbRyXki5a9vFf5w3FKQ14bpzwdmr+i08a8XnsCdhM9r0bLTpel jH/i1yPw/qTgG7vBJ/V3PXpKBUdGa/TuenetjNRJZdG4sOZtQJ9YWdRnPCeFgzKA/ECP rA7XfjrGubyvrKufBVeSMEvcgdnV0LC9PVf6Ufm2MrtL+vXpFDo9Zd2/kJmYoZ4+DBaK mK+NXxh8vyUC+G3ROGAEvLGKw/mMMALyjuygHkSDYVuIvqg2KOY5qOkYOPTdNBmkZzcK wGsyxOZmt7xTq3yTMJtpOOmtSalzyeqN6n4c8cPiFCLXQpa9uTv0ycANH0BHzzlaPEav rkOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tHarhIC2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x18-20020a63f712000000b0042ba115ccaasi2103802pgh.269.2022.09.20.07.50.06; Tue, 20 Sep 2022 07:50:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tHarhIC2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231451AbiITOad (ORCPT + 99 others); Tue, 20 Sep 2022 10:30:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231688AbiITOaZ (ORCPT ); Tue, 20 Sep 2022 10:30:25 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 665E33F1C8; Tue, 20 Sep 2022 07:30:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8305AB82A47; Tue, 20 Sep 2022 14:30:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96BA9C433C1; Tue, 20 Sep 2022 14:30:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663684205; bh=I74h6Nr+i8FTSqMM2icXg4l/Z8d01teWye2vzkJV1Yo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tHarhIC2/v9gdXe8pFO5gXOuAP/7hsBnlKicHFa4HPoAj/rpPDrietRKjaL4T/Jh6 ZdvbDq80prp81jUORiUO9QansekQg8YHYHrA/R14iIDhXbuZJ6QtnH7cqPeFWF3ztD hXqC/4Y/dT7gwvq0UdYzLgOqKA3n2d2nlyxTAiBUVFmdRu+VxNIRAFji/s14TQFyn8 S8G767aHCoBNK/rt2XKGk+/82GueazboMFIICcJantWmx7ibIkRvX6LXAnU6dJkEYK ldsGZtRZ71AmJhh1Sqq26kmLwBrRPtpgwZqJozUz+lUd44jaF22Zy7BkoIoRfKrK5Y kNf+jquNSTU3w== Date: Tue, 20 Sep 2022 07:30:03 -0700 From: Jakub Kicinski To: Nathan Huckleberry Cc: Dan Carpenter , llvm@lists.linux.dev, "David S. Miller" , Eric Dumazet , Paolo Abeni , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Nathan Chancellor , Nick Desaulniers , Tom Rix , Horatiu Vultur , Casper Andersson , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: sparx5: Fix return type of sparx5_port_xmit_impl Message-ID: <20220920073003.5dab2753@kernel.org> In-Reply-To: <20220912214432.928989-1-nhuck@google.com> References: <20220912214432.928989-1-nhuck@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Sep 2022 14:44:29 -0700 Nathan Huckleberry wrote: > -int sparx5_port_xmit_impl(struct sk_buff *skb, struct net_device *dev) > +netdev_tx_t sparx5_port_xmit_impl(struct sk_buff *skb, struct net_device *dev) Similarly to mana this has a prototype.