Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4050472rwb; Tue, 20 Sep 2022 08:10:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM78dJG3JkRaLJBPvUihLTig7lVmHFrFDct3sqP1YQc4MTjTrHQonmUK5RfHezFgmGTmkHH2 X-Received: by 2002:a17:907:9718:b0:77b:45b6:b047 with SMTP id jg24-20020a170907971800b0077b45b6b047mr17250412ejc.479.1663686616658; Tue, 20 Sep 2022 08:10:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663686616; cv=none; d=google.com; s=arc-20160816; b=py6qWlaMS+PKvtWf3KaGMN2mpp3NO72mFyNOD/tuCUCKSNClSG4aSiJAUZlRd+zLs6 nOcXjfJZ5a8Ivcv960g7BRYCmflWxl3tSdcOcymSYctUUKt1mQDz3NGJNyyK6SqU0fv3 os8/ZgIfmr860KmsS7W6HbtPsQesTRD0/3zFq2XH75q5KfUlP8rUxD7Ihe1wPtRRzdRv vGN31UwFXSqmvdsASiR4iASiUx6dazbptfBveYpS9zbgugP6EcTNwV+HjpPZbC6yyjz1 HRCljp9ywWkA5dBZyGcCPWmLU2NaP2kgy5zWv1z2ocR3TNNl86mf/Vtp+Y5XNYKOB2Ga j/ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=/iaUD6VHDEtimquJyXIySCxRgIY+m+5aqcf8HT19EIs=; b=G5Jtw2WB1r3HcTBhWW5RracJ84X1WyQsk0qyltIVk2xQnSbItL4V5v06vQYuI/RdEZ T3jah0LWvjbPkDpBNBHcd9k6bRX5qQsW6jHggwd852JUu13/3VMfuWgTW7YM7HTjXLtC Tv95ZVtJSRcI0Gwjdwx9pjnBcTdhgx8PXuiIXbPIZoRonD8dHBgqCjMlweznww1PABW6 GqRhwyCye0Zg22tkmgGCIz1EhlY8yS7+3C10C094U80UzG/bSdeYZdHPTBytU3wRJCFg sN9JSie/OA/HIl3ysXVPD6zVso0u42QGCmIFCBgk3BWIw7R/lz0Yvuu3k8iDPqhZmswB 0DGQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mp34-20020a1709071b2200b007413f3f0acbsi2800ejc.357.2022.09.20.08.09.49; Tue, 20 Sep 2022 08:10:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231786AbiITOZv (ORCPT + 99 others); Tue, 20 Sep 2022 10:25:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231839AbiITOZQ (ORCPT ); Tue, 20 Sep 2022 10:25:16 -0400 X-Greylist: delayed 463 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 20 Sep 2022 07:25:03 PDT Received: from sym2.noone.org (sym.noone.org [178.63.92.236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFA572E9DC; Tue, 20 Sep 2022 07:25:03 -0700 (PDT) Received: by sym2.noone.org (Postfix, from userid 1002) id 4MX3XF3jCKzvjfn; Tue, 20 Sep 2022 16:17:17 +0200 (CEST) Date: Tue, 20 Sep 2022 16:17:17 +0200 From: Tobias Klauser To: Jiri Slaby Cc: gregkh@linuxfoundation.org, Ilpo =?iso-8859-1?Q?J=E4rvinen?= , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 02/10] tty: serial: clean up stop-tx part in altera_uart_tx_chars() Message-ID: <20220920141716.kqvtrqfyaf5e3ijq@distanz.ch> References: <20220920052049.20507-1-jslaby@suse.cz> <20220920052049.20507-3-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920052049.20507-3-jslaby@suse.cz> User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-09-20 at 07:20:42 +0200, Jiri Slaby wrote: > The "stop TX" path in altera_uart_tx_chars() is open-coded, so: > * use uart_circ_empty() to check if the buffer is empty, and > * when true, call altera_uart_stop_tx(). > > Cc: Tobias Klauser > Signed-off-by: Jiri Slaby Acked-by: Tobias Klauser