Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <10bd1f39-3971-90ee-5fe4-c44005cdfcc8@linaro.org>
Date:   Tue, 20 Sep 2022 17:59:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH v3] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0
Content-Language: en-US
To:     Viorel Suman <viorel.suman@oss.nxp.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Viorel Suman <viorel.suman@nxp.com>,
        Shenwei Wang <shenwei.wang@nxp.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20220919132236.264382-1-viorel.suman@oss.nxp.com>
 <c86d39c9-82d2-0f9f-9836-76ad3b6d8ede@linaro.org>
 <20220919180631.x2telgn6d7woggmz@fsr-ub1664-116>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220919180631.x2telgn6d7woggmz@fsr-ub1664-116>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19/09/2022 20:06, Viorel Suman wrote:
43
>>>  #define IMX_SC_R_SECVIO			44
>>>  #define IMX_SC_R_DC_1_VIDEO0		45
>>>  #define IMX_SC_R_DC_1_VIDEO1		46
>>>  #define IMX_SC_R_DC_1_FRAC0		47
>>> +#define IMX_SC_R_V2X			48
>>>  #define IMX_SC_R_DC_1			49
>>> +#define IMX_SC_R_UNUSED14		50
>>>  #define IMX_SC_R_DC_1_PLL_0		51
>>>  #define IMX_SC_R_DC_1_PLL_1		52
>>>  #define IMX_SC_R_SPI_0			53
>>> @@ -151,10 +154,10 @@
>>>  #define IMX_SC_R_DMA_1_CH29		137
>>>  #define IMX_SC_R_DMA_1_CH30		138
>>>  #define IMX_SC_R_DMA_1_CH31		139
>>> -#define IMX_SC_R_UNUSED1		140
>>
>> This one disappears...
> 
> Hi Krzysztof,
> 
> Right, it was renamed in the subsequent SCFW kit
> versions to IMX_SC_R_V2X_PID0, thus - this patch
> rename it in include/dt-bindings/firmware/imx/rsrc.h
> file in order to have this file and SCFW kit defines
> synchronized.
> 
> IMX_SC_R_UNUSED1 is not referenced somehow in kernel,
> thus - no compilation issues if renamed to IMX_SC_R_V2X_PID0,
> IMHO it does not make sense to me to add the related
> backward compatibility define like below:
> 
> #define IMX_SC_R_UNUSED1 IMX_SC_R_V2X_PID0

The bindings are used by other people (other Linux kernel forks) and by
other projects (like bootloaders and other operating systems). This is
why once set, we do not change them, with some exceptions.

Best regards,
Krzysztof