Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Sep 2022 17:48:56 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Jianglei Nie <niejianglei2021@163.com>
Cc:     kuba@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HSI: ssi_protocol: fix potential resource leak in
 ssip_pn_open()
Message-ID: <20220920154856.4s675wv7koivvpgb@mercury.elektranox.org>
References: <20220905074801.46167-1-niejianglei2021@163.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="evlazoyrppugj4l4"
Content-Disposition: inline
In-Reply-To: <20220905074801.46167-1-niejianglei2021@163.com>
Precedence: bulk


--evlazoyrppugj4l4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Sep 05, 2022 at 03:48:01PM +0800, Jianglei Nie wrote:
> ssip_pn_open() claims the HSI client's port with hsi_claim_port(). When
> hsi_register_port_event() gets some error and returns a negetive value,
> the HSI client's port should be released with hsi_release_port().
>=20
> Fix it by calling hsi_release_port() when hsi_register_port_event() fails.
>=20
> Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
> ---
>  drivers/hsi/clients/ssi_protocol.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi=
_protocol.c
> index 21f11a5b965b..49ffd808d17f 100644
> --- a/drivers/hsi/clients/ssi_protocol.c
> +++ b/drivers/hsi/clients/ssi_protocol.c
> @@ -931,6 +931,7 @@ static int ssip_pn_open(struct net_device *dev)
>  	if (err < 0) {
>  		dev_err(&cl->device, "Register HSI port event failed (%d)\n",
>  			err);
> +		hsi_release_port(cl);
>  		return err;
>  	}
>  	dev_dbg(&cl->device, "Configuring SSI port\n");

Thanks, queued.

-- Sebastian

--evlazoyrppugj4l4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmMp4NQACgkQ2O7X88g7
+ponFRAAkqXj33I9pMg7pk8MlREeWZlbFSjx83m8YR7nLSgfFAMXt4qI01QJa5/k
3FbQwp9Gf13eCvauBbvzb9jXg2OukD/6GrCeVbUsxmbr8IQ9zuV3di2yzI5nCLiM
2cBaugH56SGD9PZHbrLH0Uxgh0fJEnB7ntjzfp8s1aPwscem4HZyYXxpnc+5HZGm
DrthxjWd4RpA/TgjywnPHoom9Z6v/IGQVwe2CzJmz77lWSzeCbOWVUy3ccSHSyb/
rrdiYvlrlsxh1eJYoDN+FmzBjwIFI2vn60ECtSyBpXRmDXUm6gmt4Dr7Nl+cAUes
IaBeSeJm5kqTFN39aD1xpPBqpEj+jDS2yLBye1HejPrdJrvKd9tucBmIKkGvFXoH
seBMOW+hyzrXGWA4HUxCsfk+WIjNg6RbkEqv1Q4nFjVnsaZH6vBd2oscfM4JT3mU
0Wjtk31KDgoTb1WqNl2zotkuwoLbUP7n/2c2YL1iZNLz4s2RvqQ/DSJjHjB/wyZM
aWBcQNyuSmEfklr6zrBfIkUZDQt1zUzIllk9ayFSsfxmtjS1AreeVyF4ttCn8Q9z
TGic1A7H1lq5T991sadtB2A943MT428E6zQz6g4ddO5cQ6q9KsdpMyoYVM6UpXUH
hfkmKFVEJpcJHUksYYssXkOVm3E4xFsDnDSoGxWfiNieIXlksDs=
=QnIh
-----END PGP SIGNATURE-----

--evlazoyrppugj4l4--