Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220920063503.215199-1-ye.xingchen@zte.com.cn>
In-Reply-To: <20220920063503.215199-1-ye.xingchen@zte.com.cn>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 20 Sep 2022 12:10:15 -0400
Message-ID: <CADnq5_O8DSAGzbjhz-2XD6tkAQmWMGM1d7YBngzGEmf0w-trdw@mail.gmail.com>
Subject: Re: [PATCH linux-next] drm/amd/pm: Remove the unneeded result variable
To:     cgel.zte@gmail.com
Cc:     alexander.deucher@amd.com, airlied@linux.ie,
        ye xingchen <ye.xingchen@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>, Xinhui.Pan@amd.com,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, evan.quan@amd.com,
        christian.koenig@amd.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks.

On Tue, Sep 20, 2022 at 2:35 AM <cgel.zte@gmail.com> wrote:
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value append_vbios_pptable() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
>  .../gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c  | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
> index 1e79baab753e..bd54fbd393b9 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
> @@ -195,7 +195,6 @@ static int init_powerplay_table_information(
>         struct phm_ppt_v3_information *pptable_information =
>                 (struct phm_ppt_v3_information *)hwmgr->pptable;
>         uint32_t disable_power_control = 0;
> -       int result;
>
>         hwmgr->thermal_controller.ucType = powerplay_table->ucThermalControllerType;
>         pptable_information->uc_thermal_controller_type = powerplay_table->ucThermalControllerType;
> @@ -257,9 +256,7 @@ static int init_powerplay_table_information(
>         if (pptable_information->smc_pptable == NULL)
>                 return -ENOMEM;
>
> -       result = append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
> -
> -       return result;
> +       return append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
>  }
>
>  static int vega12_pp_tables_initialize(struct pp_hwmgr *hwmgr)
> --
> 2.25.1