Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220920063600.215257-1-ye.xingchen@zte.com.cn>
In-Reply-To: <20220920063600.215257-1-ye.xingchen@zte.com.cn>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 20 Sep 2022 12:11:19 -0400
Message-ID: <CADnq5_PB=z9JeVV4c1YC6hbAXXvHPLbD=kZvOyS1QxR-WMU9Gw@mail.gmail.com>
Subject: Re: [PATCH linux-next] drm/amd/pm: Remove unneeded result variable
To:     cgel.zte@gmail.com
Cc:     alexander.deucher@amd.com, airlied@linux.ie,
        ye xingchen <ye.xingchen@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>, Xinhui.Pan@amd.com,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, evan.quan@amd.com,
        christian.koenig@amd.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

On Tue, Sep 20, 2022 at 2:36 AM <cgel.zte@gmail.com> wrote:
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value atomctrl_initialize_mc_reg_table_v2_2() directly instead
> of storing it in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
>  drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c b/drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c
> index 45214a364baa..e7ed2a7adf8f 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/polaris10_smumgr.c
> @@ -2567,15 +2567,13 @@ static uint8_t polaris10_get_memory_modile_index(struct pp_hwmgr *hwmgr)
>
>  static int polaris10_initialize_mc_reg_table(struct pp_hwmgr *hwmgr)
>  {
> -       int result;
>         struct polaris10_smumgr *smu_data = (struct polaris10_smumgr *)(hwmgr->smu_backend);
>         pp_atomctrl_mc_reg_table *mc_reg_table = &smu_data->mc_reg_table;
>         uint8_t module_index = polaris10_get_memory_modile_index(hwmgr);
>
>         memset(mc_reg_table, 0, sizeof(pp_atomctrl_mc_reg_table));
> -       result = atomctrl_initialize_mc_reg_table_v2_2(hwmgr, module_index, mc_reg_table);
>
> -       return result;
> +       return atomctrl_initialize_mc_reg_table_v2_2(hwmgr, module_index, mc_reg_table);
>  }
>
>  static bool polaris10_is_dpm_running(struct pp_hwmgr *hwmgr)
> --
> 2.25.1