Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Sep 2022 10:34:43 -0600
From:   Alex Williamson <alex.williamson@redhat.com>
To:     Longfang Liu <liulongfang@huawei.com>
Cc:     <jgg@nvidia.com>, <shameerali.kolothum.thodi@huawei.com>,
        <cohuck@redhat.com>, <linux-kernel@vger.kernel.org>,
        <linuxarm@openeuler.org>
Subject: Re: [PATCH 1/5] hisi_acc_vfio_pci: Fixes a memory leak bug
Message-ID: <20220920103443.72654dd7.alex.williamson@redhat.com>
In-Reply-To: <20220915013157.60771-2-liulongfang@huawei.com>
References: <20220915013157.60771-1-liulongfang@huawei.com>
        <20220915013157.60771-2-liulongfang@huawei.com>
Organization: Red Hat
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 15 Sep 2022 09:31:53 +0800
Longfang Liu <liulongfang@huawei.com> wrote:

> During the stop copy phase of live migration, the driver allocates
> a memory for the migrated data to save the data.
> 
> When an exception occurs when the driver reads device data, the driver
> will report an error to qemu and exit the current migration state.
> But this memory is not released, which will lead to a memory
> leak problem.
> 
> So we need to add a memory release operation.
> 
> Reviewed-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> Signed-off-by: Longfang Liu <liulongfang@huawei.com>
> ---
>  drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c b/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c
> index ea762e28c1cc..8fd68af2ed5f 100644
> --- a/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c
> +++ b/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c
> @@ -828,15 +828,15 @@ hisi_acc_vf_stop_copy(struct hisi_acc_vf_core_device *hisi_acc_vdev)
>  		return ERR_PTR(err);
>  	}
>  
> -	stream_open(migf->filp->f_inode, migf->filp);
> -	mutex_init(&migf->lock);
> -
>  	ret = vf_qm_state_save(hisi_acc_vdev, migf);
>  	if (ret) {
> -		fput(migf->filp);

Sorry, why did this fput() get removed?  Thanks,

Alex

> +		kfree(migf);
>  		return ERR_PTR(ret);
>  	}
>  
> +	stream_open(migf->filp->f_inode, migf->filp);
> +	mutex_init(&migf->lock);
> +
>  	return migf;
>  }
>