Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220826184500.1940077-1-vipinsh@google.com>
In-Reply-To: <20220826184500.1940077-1-vipinsh@google.com>
From:   Vipin Sharma <vipinsh@google.com>
Date:   Tue, 20 Sep 2022 09:31:20 -0700
Message-ID: <CAHVum0eUsVoJKJ1X+qmW-6jRoag=QZW2RD46_Ez2489qy8ps5w@mail.gmail.com>
Subject: Re: [PATCH v3 0/4] dirty_log_perf_test cpu pinning and some goodies
To:     seanjc@google.com, dmatlack@google.com, pbonzini@redhat.com
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Aug 26, 2022 at 11:45 AM Vipin Sharma <vipinsh@google.com> wrote:
>
> Pin vcpus to a host physical cpus in dirty_log_perf_test and optionally
> pin the main application thread to a physical cpu if provided. All tests
> based on perf_test_util framework can take advantage of it if needed.
>
> While at it, I changed atoi() to atoi_paranoid() in other tests, sorted
> command line options alphabetically, and made switch case logic of -e
> option less error prone to code changes by adding break and decoupling
> it from -g.
>
> v3:
> - Moved atoi_paranoid() to test_util.c and replaced all atoi() usage
>   with atoi_paranoid()
> - Sorted command line options alphabetically.
> - Instead of creating a vcpu thread on a specific pcpu the thread will
>   migrate to the provided pcpu after its creation.
> - Decoupled -e and -g option.
>
> v2: https://lore.kernel.org/lkml/20220819210737.763135-1-vipinsh@google.com/
> - Removed -d option.
> - One cpu list passed as option, cpus for vcpus, followed by
>   application thread cpu.
> - Added paranoid cousin of atoi().
>
> v1: https://lore.kernel.org/lkml/20220817152956.4056410-1-vipinsh@google.com
>
> Vipin Sharma (4):
>   KVM: selftests: Explicitly set variables based on options in
>     dirty_log_perf_test
>   KVM: selftests: Put command line options in alphabetical order in
>     dirty_log_perf_test
>   KVM: selftests: Add atoi_paranoid to catch errors missed by atoi
>   KVM: selftests: Run dirty_log_perf_test on specific cpus
>
>  .../selftests/kvm/aarch64/arch_timer.c        |  8 +--
>  .../testing/selftests/kvm/aarch64/vgic_irq.c  |  6 +-
>  .../selftests/kvm/access_tracking_perf_test.c |  2 +-
>  .../selftests/kvm/demand_paging_test.c        |  2 +-
>  .../selftests/kvm/dirty_log_perf_test.c       | 65 +++++++++++++------
>  .../selftests/kvm/include/perf_test_util.h    |  4 ++
>  .../testing/selftests/kvm/include/test_util.h |  2 +
>  .../selftests/kvm/kvm_page_table_test.c       |  2 +-
>  .../selftests/kvm/lib/perf_test_util.c        | 62 +++++++++++++++++-
>  tools/testing/selftests/kvm/lib/test_util.c   | 14 ++++
>  .../selftests/kvm/max_guest_memory_test.c     |  6 +-
>  .../kvm/memslot_modification_stress_test.c    |  4 +-
>  .../testing/selftests/kvm/memslot_perf_test.c | 10 +--
>  .../selftests/kvm/set_memory_region_test.c    |  2 +-
>  .../selftests/kvm/x86_64/nx_huge_pages_test.c |  4 +-
>  15 files changed, 148 insertions(+), 45 deletions(-)
>
> --
> 2.37.2.672.g94769d06f0-goog
>

Knock Knock!!