Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Sep 2022 22:32:46 +0530
From:   "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
Subject: Re: [PATCH 0/2] make weak attributes in {k,u}probes
To:     anil.s.keshavamurthy@intel.com, borntraeger@linux.ibm.com,
        catalin.marinas@arm.com, dave.hansen@linux.intel.com,
        gor@linux.ibm.com, guoren@kernel.org, hca@linux.ibm.com,
        hpa@zytor.com, linux-arm-kernel@lists.infradead.org,
        linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org,
        linux-s390@vger.kernel.org, mark.rutland@arm.com,
        mhiramat@kernel.org, namit@vmware.com, palmer@dabbelt.com,
        paul.walmsley@sifive.com, peterz@infradead.org, x86@kernel.org,
        Yipeng Zou <zouyipeng@huawei.com>
Cc:     chris.zjh@huawei.com, liaochang1@huawei.com
References: <20220917015522.44583-1-zouyipeng@huawei.com>
In-Reply-To: <20220917015522.44583-1-zouyipeng@huawei.com>
User-Agent: astroid/4d6b06ad (https://github.com/astroidmail/astroid)
Message-Id: <1663692878.h3l8c563n8.naveen@linux.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

Yipeng Zou wrote:
> We have some function implementation under some arch does nothing.
> We can mark it with weak attributes to improve.

That's not always an improvement. See [1] for an example, among many=20
other patches to reduce use of __weak functions in the kernel.

As an alternative, please consider the approach used in [1].


- Naveen

[1] https://lore.kernel.org/all/20220519091237.676736-1-naveen.n.rao@linux.=
vnet.ibm.com/