Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4336963rwb; Tue, 20 Sep 2022 12:17:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5rrqB+WCLZT3CfdmNCCaPY5TQh6E6GJb1o8IcQZYGRBn4WhKr1PkfzbVYDDFT1S09q+aM0 X-Received: by 2002:a05:6a02:202:b0:42b:d711:f27c with SMTP id bh2-20020a056a02020200b0042bd711f27cmr21409536pgb.246.1663701463108; Tue, 20 Sep 2022 12:17:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663701463; cv=none; d=google.com; s=arc-20160816; b=o4pxw1CkcjQd+B3Sd6Je8ypXlpUl/buowxRPIi4xmcg1GDzwQ2Oom+wG6/AtCoGKcM xCRlz1T8rg29F/MPWYMPvepNvFLRa+Wp6Sjv5nRbGwrF5Akc5TlGMr6gzMGodXQ/d97E AAB2Xf9gdmiAy5ZaS95HBFgau2BvcuaZ9jScyJ5ihKJyUok9EfQ8dMe6TbMBEz3/pMK/ V0TltfRRei/Yh6T7EOtuL0BLwmgDeiL+8qY3KhQVELqIxGgPTDwthdq0bPofBtumBH0u LclElH39ECM2Tl02e0YuZWZ4GptIPGlJeMfUWKP0xs3JHvq9iuJ8aA+i38WGa6SmHfUS dHew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=e1rax8zHktkJE4NlsAmrfBmfy6JQLwKUdVTmbuE0Kvk=; b=GyPWyHUhguELSg/xwlK5NeVWAeD+4+2szLyfZTet1CnJw0ipEJm7MLxdm5yW0hMgFW jsVbamVL8ONrti2bYeeJam01GVLWJuLFOWlRG0AoStHnQ3n2Pe4H0r5iLEGDmOcBakmi INyXjpyFOWhIVguTkKK0GXFEVwSm09pUOrj9IvNlCOzaRPNsrADoz5oi7ipEpqIFmRu9 O5VmmD0uYr3Yx4rBXGWin7Zaw6FWNDllc7XxCruRBVjLJg3nxmhuUHl6L6zHHkqtBsm/ iCMKmHJxV9P9vwUcF6a0gQORoBXoe/3Jh7gIQvNU9AIcozxDSlb2Ocj6vhObvBwTBb3k +95Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b="a/n6KLKy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q27-20020a63751b000000b0041a4f434cecsi545384pgc.798.2022.09.20.12.17.31; Tue, 20 Sep 2022 12:17:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b="a/n6KLKy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230325AbiITSsA (ORCPT + 99 others); Tue, 20 Sep 2022 14:48:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230020AbiITSr6 (ORCPT ); Tue, 20 Sep 2022 14:47:58 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B1FD719B8 for ; Tue, 20 Sep 2022 11:47:57 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id i203-20020a1c3bd4000000b003b3df9a5ecbso7532363wma.1 for ; Tue, 20 Sep 2022 11:47:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=e1rax8zHktkJE4NlsAmrfBmfy6JQLwKUdVTmbuE0Kvk=; b=a/n6KLKyuuFnUM9vPXO3YclSzmLnz5UmmI77Eu3qAaW7GkwFECSgfrEM4d7ThRkn+b ZTMsEBSKTuD7zZiQVnWgjr07lcGlSZ9GvvEgMm0rhzp6C0aGUGevKgOvhoTx7JxtonZC cRH+h/UsrueXTDj97dWDJ+LJl89I4BlMeysqwnhpKoX3kUbWiKuuMaXAF8Zpx1L8spQA Hk/fmXNFF5Mygf7rmhKqwumIZA0iLEqpSsNbVh8OcqU9iYKYY9QYErbSUiNfkFYXOFPR LAi4v5NqDj/zYgN5BQZ8iCvyfyDZ/LxZM9kQpWnHtWqeAGSezF8VPy4ng6kbwnRmQpE9 Sp7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=e1rax8zHktkJE4NlsAmrfBmfy6JQLwKUdVTmbuE0Kvk=; b=G3bmRkog5Qz752B53brzHv5a4p7ccSAlPPokywoq+WkpZ+5KJZqJ5PDfl2IygLXZIf fgEN6Jb30SvuAITGF1Vk9sbU3D9R8bDRKQgUFbzT/xHHMACI/V1ZDlI+316rWaKUJv6T BR7dzppe+2U5F/mEHe16emiEgywTRlw9+lwNsMsEvAI7t9l6ZDN4J2/mLIiGJu1dsBTr erwsAj1Izb6o9y0stR3BvYSQinpM/o3v61/vpZ4ea7+HqZ/ALYLTwjyKaJ6NIBlKXy8x 5zRK4jBy54fcD4w5axzmehkwUGe+1jpyE024/SLPAmP4uOjbbB/uDsnnzYcfdM9tXfzc MYVQ== X-Gm-Message-State: ACrzQf342aZffEe/Ba+3L59VJHVPkAMyk0HEpGYUsiOe/XRFCgKy0vXn 4zbjyMMgQX0oW4SyZs5gbbYhtg== X-Received: by 2002:a05:600c:310b:b0:3b4:c709:4322 with SMTP id g11-20020a05600c310b00b003b4c7094322mr3342558wmo.141.1663699676003; Tue, 20 Sep 2022 11:47:56 -0700 (PDT) Received: from localhost.localdomain (host-78-150-37-98.as13285.net. [78.150.37.98]) by smtp.gmail.com with ESMTPSA id id21-20020a05600ca19500b003b27f644488sm507061wmb.29.2022.09.20.11.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 11:47:55 -0700 (PDT) From: Sudip Mukherjee To: Tudor Ambarus , Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: greentime.hu@sifive.com, jude.onyenegecha@sifive.com, william.salmon@sifive.com, adnan.chowdhury@sifive.com, ben.dooks@sifive.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH v3 1/2] mtd: spi-nor: issi: is25wp256: Init flash based on SFDP Date: Tue, 20 Sep 2022 19:47:48 +0100 Message-Id: <20220920184748.44812-1-sudip.mukherjee@sifive.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The datasheet of is25wp256 says it supports SFDP. Get rid of the static initialization of the flash parameters and init them when parsing SFDP. Testing showed the flash using SPINOR_OP_READ_1_1_4_4B 0x6c, SPINOR_OP_PP_4B 0x12 and SPINOR_OP_BE_4K_4B 0x21 before enabling SFDP. After this patch, it parses the SFDP information and still uses the same opcodes. Signed-off-by: Sudip Mukherjee --- No change from v2, just resending again with the next patch. Results from the tests given by Tudor in the following mail. drivers/mtd/spi-nor/issi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c index 89a66a19d754f..8b48459b5054c 100644 --- a/drivers/mtd/spi-nor/issi.c +++ b/drivers/mtd/spi-nor/issi.c @@ -71,7 +71,7 @@ static const struct flash_info issi_nor_parts[] = { { "is25wp128", INFO(0x9d7018, 0, 64 * 1024, 256) NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { "is25wp256", INFO(0x9d7019, 0, 64 * 1024, 512) - NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) + PARSE_SFDP FIXUP_FLAGS(SPI_NOR_4B_OPCODES) .fixups = &is25lp256_fixups }, -- 2.30.2