Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Sep 2022 11:36:23 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Li Zhong <floridsleeves@gmail.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        intel-wired-lan@lists.osuosl.org, pabeni@redhat.com,
        edumazet@google.com, davem@davemloft.net,
        anthony.l.nguyen@intel.com, jesse.brandeburg@intel.com
Subject: Re: [PATCH v2] drivers/net/ethernet/intel/e100: check the return
 value of e100_exec_cmd()
Message-ID: <20220920113623.2f041e80@kernel.org>
In-Reply-To: <20220917001027.3799634-1-floridsleeves@gmail.com>
References: <20220917001027.3799634-1-floridsleeves@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 16 Sep 2022 17:10:27 -0700 Li Zhong wrote:
> Check the return value of e100_exec_cmd() which could return error code
> when execution fails.

You need to provide more detailed analysis in the commit message.
Right now it looks like you're just blindly finding cases where
return value is not checked and adding error checks. This is as
likely to fix something as it is to break.