Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Sep 2022 22:25:55 +0300
From:   Serge Semin <Sergey.Semin@baikalelectronics.ru>
To:     Damien Le Moal <damien.lemoal@opensource.wdc.com>
CC:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the libata tree
Message-ID: <20220920192555.s3256bkmv3b5sthq@mobilestation>
References: <20220919124034.58670a27@canb.auug.org.au>
 <6f9b5fd7-8a8a-619e-f758-216cadd8ea08@opensource.wdc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <6f9b5fd7-8a8a-619e-f758-216cadd8ea08@opensource.wdc.com>
Precedence: bulk

Hello Damien

On Tue, Sep 20, 2022 at 08:56:53AM +0900, Damien Le Moal wrote:
> On 9/19/22 11:40, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the libata tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> > 
> > drivers/ata/ahci_st.c: In function 'st_ahci_probe':
> > drivers/ata/ahci_st.c:147:24: warning: unused variable 'dev' [-Wunused-variable]
> >   147 |         struct device *dev = &pdev->dev;
> >       |                        ^~~
> > 
> > Introduced by commit
> > 
> >   3f74cd046fbe ("ata: libahci_platform: Parse ports-implemented property in resources getter")
> > 
> 

> I pushed a fix for this. I also added a dependency on COMPILE_TEST for
> this driver to avoid a repeat in the future.

I'm sorry for not delivering a quick response to the request. Thanks
for sending the fix. Indeed the dev variable should have been dropped.
I should have checked that after removing a part of the code some
variables could be left unused.

-Sergey

> 
> Thanks.
> 
> -- 
> Damien Le Moal
> Western Digital Research
>