Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4369466rwb; Tue, 20 Sep 2022 12:55:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7cI46Vpzs92Tgg7MZojjg62K3/v72s2KwUk7cAMK2w5QtD2acedTFDICfDxENsKOTFW+t2 X-Received: by 2002:a17:90a:d583:b0:202:a064:3a32 with SMTP id v3-20020a17090ad58300b00202a0643a32mr5604364pju.75.1663703720799; Tue, 20 Sep 2022 12:55:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663703720; cv=none; d=google.com; s=arc-20160816; b=sEu6A9A1p8IXCwkcnG4LsSf5CrfrcZfrkaPylBDtpqJtHoaRdbt+tp2qvyhPJTcBLt yXz3M8Q8meHu976JTAmauC1i8FxtDBXzINLHaMJPihFwlQ2RnpoBcdKdjfa8FHriCreB Y3WceMbZgSusRupcreFnBjUQ2ynER+dywiTGCWO1UKRY30tOkyXSIinb7bzYFIva63FS m8MNaZGgpUsljQWL9CE+/1h2XGz2KD2hdeLDJRTk/qVusENlpqrasZmWP/6h35dxzHfG Z3iIdxV6gLxGMoi0Xggjf6c3BkxcM/ao9+Lud2NO6+pi7H75hID1A6zGjVGD03fksWNE HojQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=w048zwwhBkv0Lv1DpYhCfBT+EYeKMdKOeRn9gAJwd38=; b=lJ/k/7IkZ85fUDi4vtITMyX79UeLO8IJ9/z/yijMS3NxsCu/QxHQUWeunarFs3TFME /3lwQk9T2oepFhLT0cJKSHgPp85iRT/pi1ruZ4pc+YymkVAU4AhaSoo5kc7xH2CTVGEd yA0J9Ej+SePkyGPRY85vJzOJmfARdfX0+c3dBRQ4Lt2EtwLiRrA6d/40oMoFvUIcYLEJ zSasQklZ+NyPADxmCAV1wS1tUFfJV0K27W9fUULlPLl7vQhuPREnozwxb2xZpHKdjj17 wg+AfFbkV64wbqUWaoNPaezcImbL1Vs4w74g796UQhlSRntJDBTRa7xHpGv+j63XzYVI WJ9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NZrnrzs1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g128-20020a636b86000000b00439f20b4af7si565771pgc.831.2022.09.20.12.55.08; Tue, 20 Sep 2022 12:55:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NZrnrzs1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230130AbiITShz (ORCPT + 99 others); Tue, 20 Sep 2022 14:37:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230415AbiITShs (ORCPT ); Tue, 20 Sep 2022 14:37:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 187F57435C; Tue, 20 Sep 2022 11:37:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C6B07B82C38; Tue, 20 Sep 2022 18:37:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E266C433D7; Tue, 20 Sep 2022 18:37:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663699065; bh=EevUVUgTemyy3pi8j8ML87dKQSxdA/iB4mYtejbDRq0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NZrnrzs1qBSwaZv0mI50czcHyki7jpYOdd78bggNqjhQzQ6u1bR26pt4bEtVHWbRz ZbYKiVRpt9bJn4eN+/7b8Nz621xorekXabXN0ZinEZsCaHwXqSInfuG4IoUlXX/ILP QWjMg8SGk0HTxTDZcsrC067+W2Zpz2/ja3SK7Tb9SIR/ICHf2Je5Y6nwkEmJrKMlo4 f4E5/pjIhJIVgzmp4aSb3/iVBltdFQ5dvrIe5yrqU2w6C7GTWfVqEKuu2fXwLEJnzI /E9YoEub4LkBeSzTDWdLd+j/7+MWWUpPueh2y9R2GgJNsq5TeSAky3p4bzMgjHyt5d ZXZlX2s9zz+og== Date: Tue, 20 Sep 2022 11:37:44 -0700 From: Jakub Kicinski To: Li Zhong Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com, davem@davemloft.net Subject: Re: [PATCH v1] net/ethtool/tunnels: check the return value of nla_nest_start() Message-ID: <20220920113744.64b16924@kernel.org> In-Reply-To: <20220917022602.3843619-1-floridsleeves@gmail.com> References: <20220917022602.3843619-1-floridsleeves@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Sep 2022 19:26:02 -0700 Li Zhong wrote: > goto err_cancel_table; > > entry = nla_nest_start(skb, ETHTOOL_A_TUNNEL_UDP_TABLE_ENTRY); > + if (!entry) > + return -EMSGSIZE; not even correct, and completely harmless