Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4371304rwb; Tue, 20 Sep 2022 12:57:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM46WTlgDUddJLRiIUvo6xACOgVGMVogC/0nAnSrqeVpoMowgcSYcKbXoAF2FFwfdH5tN6/h X-Received: by 2002:a17:90a:9281:b0:203:19a9:e57e with SMTP id n1-20020a17090a928100b0020319a9e57emr5561026pjo.97.1663703851867; Tue, 20 Sep 2022 12:57:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663703851; cv=none; d=google.com; s=arc-20160816; b=AIXkwrvQima8RuSMdBKjxxu/On65TtW5pH0IfNNxIro/0JZ4grm7varnl3dEiZ/+RJ J+Ja69vUd7Y9Q8rmXl4V4ovf0e5w3rhav9PLURw3pAHTcehiEjTbxmYxsTHA0Fi6spFt 8w83hLCstmRM3fS2LaPUAqPiu4tUb2VqKkBbP538tT25nml8d/+CIBd2NWVgOfHwkEhx W5wLkXNISJ2JDmfBw1h2o4qpBbthGSaMcc7BpOBmXiHVIbd+GaEBEvZm5ZP5iGbYJBv7 F3tRvVFUUsUFxnijvTdRBtL63n+Ohnof+yMpA8873zAO3M5mpFEvlu1NI68qPzxjtegV DImA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=rDI2k9IWsr/i0/2WgbBmi/CA3PwHQ/Lv6drlAZX4PD4=; b=hDGG5/Og3vw41+krmxt2W1o0jk3htD0BRdxoVudgAX8rjpiHR7NVo957G1W6k90gOO 5zChR+eX5jXvAR2xv43gLhJBdIKDzCI7ukU83isqdkhHP4zLZpy9NUGZ98Xyem9HZNAV MWwTuuf+IqCShS0ORplbCTST3f8gu0KVFmtIHMzxii8EDsJwyqv2Snp/PQCMFvq+oEuy twKGwIPE6doV8g8r5rc/ElccjtS3Asvq0TqNVX0LYL8Pn6kYo7lXKBmVl5g/p7d+SxUy rjWeLTJXBtT0tCqtnZTvNgdr1M+xLU8ZF0k22jDrgLKOPMbdjZOJs80TiFAJP4pbYVth FYRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=keOkbiAd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d19-20020a63ed13000000b0042b52f42418si612840pgi.227.2022.09.20.12.57.20; Tue, 20 Sep 2022 12:57:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=keOkbiAd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231476AbiITTgt (ORCPT + 99 others); Tue, 20 Sep 2022 15:36:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230463AbiITTgn (ORCPT ); Tue, 20 Sep 2022 15:36:43 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BA137285E; Tue, 20 Sep 2022 12:36:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 52DD7CE1818; Tue, 20 Sep 2022 19:36:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C9BAC433D6; Tue, 20 Sep 2022 19:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663702598; bh=4ZpzzM0pT1v5jAnKUiINLrDLktKeYd1gJkLXgUwydEA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=keOkbiAdYB+4hivymCR3mlUc273Ihc3cNdwCzFyPDi2h9wdNeU953uc7RcXVoQKVL eK/Q1Ai70jBosUTCuHoULUQAk7bwn+BEGklv87O6dVniTjT0809IDykPFORuqRi5PW uMT+t4p8MNdXVLwGkJMvuiDnQefAA4qsK75+XPMNi8Lj61J5VrY78gOLaNpRp9xPyJ i9AW6aGHma2brcLP4wsgpJkaoGGm+VE5W8Nieq/ul/uh0FiUsSNS7DExuVbjOxumpY 3pUoErkRo6RSBTj1maplblL85Zo/8RFxl3Qjm3HT9NFEI7ixiglVds1YtS12VbMAxq rpRYpoM04vn9g== Date: Tue, 20 Sep 2022 12:36:37 -0700 From: Jakub Kicinski To: Sean Anderson Cc: "David S . Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org (open list), Zheyu Ma , Nick Bowler , Rolf Eike Beer Subject: Re: [PATCH net-next 05/13] sunhme: Regularize probe errors Message-ID: <20220920123637.1ade6b2d@kernel.org> In-Reply-To: <20220918232626.1601885-6-seanga2@gmail.com> References: <20220918232626.1601885-1-seanga2@gmail.com> <20220918232626.1601885-6-seanga2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 18 Sep 2022 19:26:18 -0400 Sean Anderson wrote: > - err = -ENODEV; > + err = -EINVAL; > if ((pci_resource_flags(pdev, 0) & IORESOURCE_IO) != 0) { > printk(KERN_ERR "happymeal(PCI): Cannot find proper PCI device base address.\n"); > goto err_out_clear_quattro; > } Why not move it inside the if?