Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4373436rwb; Tue, 20 Sep 2022 13:00:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5tz4l1Na4QcULsGTleXXWLa4GQX48xmGF3yZeJ2M1dOSQ6EiGYOJyWsfdoxOFgEV6NjXLC X-Received: by 2002:a17:902:b288:b0:177:ff40:19cf with SMTP id u8-20020a170902b28800b00177ff4019cfmr1205820plr.117.1663704003216; Tue, 20 Sep 2022 13:00:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663704003; cv=none; d=google.com; s=arc-20160816; b=stQopEmOH3mgf/grnwGDN/sQB0y1oxS8iUbDbmf6rwgppBU/hPvi56uvpsflJ1ly1E EsldIlCkk2rM//RRLe40wIem/vXAhNibuwzm+6QQgYGMPP7V11eRTdRpAhp9VNUCK3IS JmJ+d2iXdY3Gu79j9CqurxeZgTi6M4BjwyRr5OGefP+1brF1/J1Y4BiI9joTm3Jso9Rh PAhKdb7aJWf0wGMmICySzwryca1gRU9FvdI/9eMhoV6PLMaogtLq8rQ6oBUF5BKdebBF WOtmT7ZVWypPv1WfAHGkzKHN8+mwQen2tic1B6dzKJjukREVBwdOgyqku7/jcHWlO7ja WlaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=4RIZ3QgicZBvmH0sy8Abeyqbs2pT34kPf9r1pZ1MYBc=; b=t8IIjIJBBmF0Br453TcGKzBaZoqFvaredrTFH8rssQZI+gl8Cj6u8tcYxB960UUD+W YVy8pAdQ4Z02fb4nxgBuD3yRE/iW9jEmti7DN7qOa8h2uHymcOGg1zday/4N4OtMkLXn fNcOQ+xArgRTJvW4I7QykJJirN41s/2G768lmSD/Lmx9bVLM5TpN51q9Tl5Lm8ld2+Eh QojHGOobpB1/29a4iKzSr2a2UbHVcz2221n7koD7Y91GQ/4XJLIxXs83RfEnIfPklFYF ggtmXTvNUj+ZdhD3rv1Wp9qYEmEwKXapC90zt0PAPARbpYKjjzD/H+CsGPX7OrMbyPib Hy/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p0FGgQBD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a8-20020a634d08000000b0043aebb63fc6si655448pgb.81.2022.09.20.12.59.50; Tue, 20 Sep 2022 13:00:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p0FGgQBD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231563AbiITThk (ORCPT + 99 others); Tue, 20 Sep 2022 15:37:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230463AbiITTh2 (ORCPT ); Tue, 20 Sep 2022 15:37:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD67276456; Tue, 20 Sep 2022 12:37:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F37061726; Tue, 20 Sep 2022 19:37:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AF80C433D6; Tue, 20 Sep 2022 19:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663702646; bh=2r3NaHKh1FzT6RHSAyhCbSMWPn2w2ERtZgFmz0RQcU0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=p0FGgQBDFOKTTJOTg0uBqRSqR3/+Tav/OKmbMUiKepb0c+icMLnX8Dffs2d97ocz9 sW4Qclm53ZqaoEhDxB7WfVwKOznJ2EbY7JVzHht6DxAL2OmFA16tRQST7QV3rj1wNz Lw9SPIOAr7navex6ifAMz0O41JYSKYImEuf/nOO/g8+RXiWMCu3cBaWQ1xx91gJFlb DDDn0QAeogMUCE7yzuHL5s6w4WYjVpWGvb6k+LEPfwpwFslyaScRlEuabMpCQ/KFTD L2JleDJPB2KXuzPJpdckob/yJM+v3f4aCMBbcXgqGqGGZXRRvutk1vDoHlPy5srOyQ FkTvSw5OgXSlw== Date: Tue, 20 Sep 2022 12:37:25 -0700 From: Jakub Kicinski To: Sean Anderson Cc: "David S . Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org (open list), Zheyu Ma , Nick Bowler , Rolf Eike Beer Subject: Re: [PATCH net-next 03/13] sunhme: forward the error code from pci_enable_device() Message-ID: <20220920123725.79f2dc57@kernel.org> In-Reply-To: <20220918232626.1601885-4-seanga2@gmail.com> References: <20220918232626.1601885-1-seanga2@gmail.com> <20220918232626.1601885-4-seanga2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 18 Sep 2022 19:26:16 -0400 Sean Anderson wrote: > + err = pci_enable_device(pdev); > > - if (pci_enable_device(pdev)) > + if (err) No empty lines between call and retval check