Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4374494rwb; Tue, 20 Sep 2022 13:00:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5e7VjM6Il/TIKJZQ4B0UYbj8ptmHd6yLNIZ63Ff+xJwQT6ttLwKREa66HOJhNApgzrOdzT X-Received: by 2002:a17:906:db0d:b0:77b:a7cd:8396 with SMTP id xj13-20020a170906db0d00b0077ba7cd8396mr19212646ejb.264.1663704049943; Tue, 20 Sep 2022 13:00:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663704049; cv=none; d=google.com; s=arc-20160816; b=aNcUuW+ToV4NWmM4zW/njO/e7ivXMc1RypS9fNB/wf58YWxxoOSKiS0isaA81xgk6P WLX1ksMZAc1OiCUOm5p8HaBQb5qO2n3o2YN440+6zrWz1jFJzyUY/M7iNOxqYzUazMF/ qRzf212agOEswExldQISbXPTs1W2Viz4p+OkO7Y1L9+NCpUcqSr9breVIBPDD/9bnPWD IYmV1ukqgyJva+j4nv1JIxL6TDVwnJi40hb5nR8EhG5S86zh6Ytz37HkuC+QprDb4d3i wudrpBZmgpusolmEepzBJkpF7z8jDuhHbBMr1bzWIKRm/r/ZBQY3dYoO1du6isI7pAoJ qxZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=GL7D1AnJCDY1V5+dOxsmHuZub6CLkjMYNqBCtMLFYgc=; b=VxYZ/YeN9JxpWXfdax2tFVXFxvOf1tyyVdZJqKUXNQKU1e/4DXy86K/Gr8uSa+qDzC nsTJhtuCxYVphf6wp+unZ5XPtuAX9MSCxlAjiYxHnkGOZlPyGlc2RyZBPTbvXxvD37ii U9F7nQJN3k/c1+jqv8tYLEe0oJlIs0Kt03QFkHr7IZIkbXPL9GVg91Au6bJa41LsuGiL zbGQA4JupIDfSMb9Ap9EXA7Helpqcpd5z++PX+4z2mZYEJhUI3NjUv3keGuQd5ig5us2 EP4qr5ir+fUBxw+2MWfMhGKV9OBztu8Sl/Cu6uPzIxsLxPraaYHTHA9eCt3l43Rvp9Dt 4F1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WqyZcGF2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cr21-20020a170906d55500b007807e613e5bsi562471ejc.933.2022.09.20.13.00.24; Tue, 20 Sep 2022 13:00:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WqyZcGF2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231408AbiITTha (ORCPT + 99 others); Tue, 20 Sep 2022 15:37:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231477AbiITThK (ORCPT ); Tue, 20 Sep 2022 15:37:10 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F63B76745; Tue, 20 Sep 2022 12:37:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B98FAB82CA4; Tue, 20 Sep 2022 19:36:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03BA5C433D7; Tue, 20 Sep 2022 19:36:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663702617; bh=vc+69lGHPMCCcLxrixDCEv244+sZsDSrdGTsQ1p30gc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WqyZcGF2dTF31x0/Utp0jJm3AMsPT77ZDQl9NWgsxOMAaLpPVERQVT9n/Ag/J7atv d3U16UVjZEkEhNOLlpxlHHSWg4ppZSHfODBL52DjhLOQ35X0yZKe8dwJLuCpWSW3nl 9E1ePxPH17cdMdJiS6djeeW7xJ7jr2EzCDplJnm0k0gHCcCO+iQZ1OiUg05LnOqqO/ zyTd7lwDHGeYu/VMAB+fhz2xxsgvYHGWU3YETguDc+9SMIW9L24a1PLmI6VIoHXgsO /FA9IivYi9Sz3ab17Sl97iGIGhdF1HhUCFiT2EnZIUyBFGXv4EWoYr0L1np9LlPK++ KizMO6Eofzqvg== Date: Tue, 20 Sep 2022 12:36:56 -0700 From: Jakub Kicinski To: Sean Anderson Cc: "David S . Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org (open list), Zheyu Ma , Nick Bowler , Rolf Eike Beer Subject: Re: [PATCH net-next 04/13] sunhme: Return an ERR_PTR from quattro_pci_find Message-ID: <20220920123656.2647c7cd@kernel.org> In-Reply-To: <20220918232626.1601885-5-seanga2@gmail.com> References: <20220918232626.1601885-1-seanga2@gmail.com> <20220918232626.1601885-5-seanga2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 18 Sep 2022 19:26:17 -0400 Sean Anderson wrote: > + int i; > struct pci_dev *bdev = pdev->bus->self; > struct quattro *qp; reverse xmas tree variable ordering please