Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Prabhakar <prabhakar.csengg@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>,
        Conor Dooley <conor.dooley@microchip.com>
CC:     Heiko Stuebner <heiko@sntech.de>,
        Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
        Atish Patra <atishp@rivosinc.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: RE: [PATCH v4 07/10] riscv: dts: r9a07g043: Add placeholder nodes
Thread-Topic: [PATCH v4 07/10] riscv: dts: r9a07g043: Add placeholder nodes
Thread-Index: AQHYzSHUiYFQxotF30GY+2sg2SrZHa3oru6AgAAEELA=
Date:   Tue, 20 Sep 2022 19:26:13 +0000
Message-ID: <OS0PR01MB59224D591B8A227A5655ECDE864C9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <20220920184904.90495-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20220920184904.90495-8-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <OS0PR01MB5922AFDAFE3DEBBFFF875875864C9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
In-Reply-To: <OS0PR01MB5922AFDAFE3DEBBFFF875875864C9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bmYKCogikEofdc5lTxCGYUBeGEaab9lZeQhBGY92ytUdHtZIkfjNw36m8XY3?=
 =?us-ascii?Q?g+Cc/y5MWwvgTOjZ3+E5yl5n2sFmcDugH3S/yPJWmYkpuRwDm+RW72h1rpcP?=
 =?us-ascii?Q?ruH4Yw9sksnKZ1A8gi3a4B6rKYLJvLvwT3lfVv/mu6ncEYMCdvVqjlwpHp7K?=
 =?us-ascii?Q?kKDOBbDSEphcQmRHYQJgBpmV2qN8UWXCTp+TwPoHdeTxxrfxTyIkGy8JVbqd?=
 =?us-ascii?Q?d7xDvY6vmZYUrFLaDE2+GzwqyTrezZtx17zF442heS4iVz0MF7QwqaYx8zGp?=
 =?us-ascii?Q?MzyvA/KxsupM8gUV0LWZgAVGmpt7AgydImhem+GDZ33B1fqCTegkHcgK++Fr?=
 =?us-ascii?Q?h0afXBUjKcWBmbIIUIR7SGGqLXAsdFwJdsve24wJPfyu5j9p8/N29JX90oym?=
 =?us-ascii?Q?oQGLtgbnlluHZb0rO2lyGFY3u9ddNqmIB5b8coURYboSYH7hIPzoncUxYSAq?=
 =?us-ascii?Q?Uh6vdNuyeZHgXA3mIy/f6IViptDluI5sttt/lNNZV8rfLXLy84AkLTo4ABNe?=
 =?us-ascii?Q?ncueddHzH7jWmNkQU+BprPaM1F7YY5LvsTwhQhgvj9fzYbqIdWStay6j1cfK?=
 =?us-ascii?Q?9Z9z8ZCq+OQ+m/JI6/+YLXUvPQIoLFRdbdwWUUR8Ftbj2nTD0yXxwBxiiHUt?=
 =?us-ascii?Q?iLyKfmD4kmiB8BW23iZBkhSyXKiz7U+Vzm84E0auRL4TrjHJ+eCMdsKtT8nu?=
 =?us-ascii?Q?YnND1Td7/gTxfRBq6rZWoyUFFvj/BsUscnQ9GMYUWTxYnILzIXRrZ9B/c1hm?=
 =?us-ascii?Q?d+ZQc3Pp+B5Ajb1j61UvYIElUFRDYSli50QAooW4T5/sTkBlQq0bGRP8ASi1?=
 =?us-ascii?Q?ohIgVX7jPCz2CLZSXEuiPv3Ct4/FlTXG2KGScsRrU96dP1MBzEdUMgtIgBFC?=
 =?us-ascii?Q?aSaOiP4HoNn4+JB3aSi0T6yg7Qo/aVCMchBpME2ZgvxhbVMuuKqER7xM3rov?=
 =?us-ascii?Q?3/qQAXDMtW7MapxoKG+QZql1WaU3nh+Moq5S/0ly0UwIJdhWOIA4WcD8sMDX?=
 =?us-ascii?Q?r/H1qniQawUHh/ZY/TpfJPaSZV3I4gfNCx1l1cOqbNFDuDFxCOtNXvo3ne6g?=
 =?us-ascii?Q?kv33zNPkQZhYxnDW70/PsceYnVhBXzqcKFY01E7JgyYw0HYQPs7ls/c9iK/q?=
 =?us-ascii?Q?llv4dJVhVWl4iQPq9Ay0KDfOy6PgYd1L5+qalbt46oQYnh3hQCsKmhA7RTt4?=
 =?us-ascii?Q?5Tf3jzJ8fk2M1Py1FDD0BcgA7v2Q/46IUEHFqFLtzjXQxFJuR7U+lhIEc1Ik?=
 =?us-ascii?Q?dlXM0EPbNlmE3iBhiCA1dh7UVd+IRRvO37Uwo4yfdIBdpjl727lTpit/ZELj?=
 =?us-ascii?Q?BJteZJhRGcYnuCLvGtJtvhwYQ9pT5ghp/0s/pAgrJNdQRHdrD1ODJt2QO7nM?=
 =?us-ascii?Q?hSNVakeIoo6H4k0PLWRgNRdJ841VmN/ecIxVBWg3EME9RXMo3xkF3T3LBxKx?=
 =?us-ascii?Q?TCQoHVppRVZo2S6plzfnpRD+m8nEOcvRiXMojymOIVuoGLDHXaWFWPtsoi+f?=
 =?us-ascii?Q?4IOBNDbJN6UjcVE8BejaaqDqAaQWFal1e+ue43iHhC2MBd+EIARGnEfVayFZ?=
 =?us-ascii?Q?ESTC1Gs1L7jg9zE8n/zVzLQSs1PL/kn+yuxZid1KrGpyp4Mq4Xztkj1ZOQaw?=
 =?us-ascii?Q?+w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7f1f7fa-a979-4a9e-d1fb-08da9b3dfb61
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2022 19:26:13.8836
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mjLmC0O/0iRmEgh7wfVAoWVAdvQeTkD1xK36yGe6s1nAap5ZmJOesCjVTgBTgW4vEYiKhK3cNJFbISkQA+YvtnetVRlF3Z88FU2l+0qzm58=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3PR01MB10455
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Just ignore my mail, As I realised IRQ property in each node will be a prob=
lem.

Cheers,
Biju

> -----Original Message-----
> From: Biju Das
> Sent: 20 September 2022 20:22
> To: Prabhakar <prabhakar.csengg@gmail.com>; Rob Herring
> <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Paul Walmsley
> <paul.walmsley@sifive.com>; Palmer Dabbelt <palmer@dabbelt.com>;
> Albert Ou <aou@eecs.berkeley.edu>; Geert Uytterhoeven
> <geert+renesas@glider.be>; Magnus Damm <magnus.damm@gmail.com>; Conor
> Dooley <conor.dooley@microchip.com>
> Cc: Heiko Stuebner <heiko@sntech.de>; Heinrich Schuchardt
> <heinrich.schuchardt@canonical.com>; Atish Patra
> <atishp@rivosinc.com>; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-riscv@lists.infradead.org; linux-
> renesas-soc@vger.kernel.org; Prabhakar Mahadev Lad <prabhakar.mahadev-
> lad.rj@bp.renesas.com>
> Subject: RE: [PATCH v4 07/10] riscv: dts: r9a07g043: Add placeholder
> nodes
>=20
> Hi Prabhakar,
>=20
> Thanks for the patch.
>=20
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Add empty placeholder nodes to RZ/Five (R9A07G043) SoC DTSI.
> >
> > This is in preparation to reuse the RZ/G2UL SMARC SoM and carrier
> > board DTSIs([0] and [1]).
>=20
> Just a question,
>=20
> Why can't we reuse SoC dtsi as well, as 90% of the SoC nodes are same?
>=20
> Split common stuff from arch/arm/boot/dts/renesas/r9a07g043.dtsi
>=20
> and add ARM specific CPU, IRQ to
> arch/arm/boot/dts/renesas/r9a07g043u.dtsi
>=20
> RISC-V specific CPU, IRQ to
> arch/riscv/boot/dts/renesas/r9a07g043f.dtsi
>=20
> Both r9a07g043{u,f} dtsi will add common dtsi.
>=20
>=20
> Cheers,
> Biju
>=20
>=20
> >
> > As the RZ/G2UL SMARC EVK enables almost all the blocks supported by
> > the SoC and whereas for the RZ/Five SMARC EVK we will gradually be
> > enabling the blocks as a result we are adding the placeholder nodes
> to
> > avoid DTB compilation errors (currently we dont have support in DTC
> to
> > delete the reference nodes without actual nodes).
> >
> > [0] arch/arm64/boot/dts/renesas/rzg2ul-smarc-som.dtsi
> > [1] arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-
> lad.rj@bp.renesas.com>
> > ---
> > v3 -> v4
> > * Dropped status and reg-names properties
> > * Updated the commit message
> > * Note sbc node is not enabled in RZ/G2UL SMARC EVK but will be soon
> >   enabled so added a placeholder for this too.
> >
> > v2 -> v3
> > * New patch
> > ---
> >  arch/riscv/boot/dts/renesas/r9a07g043.dtsi | 150
> > +++++++++++++++++++++
> >  1 file changed, 150 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/renesas/r9a07g043.dtsi
> > b/arch/riscv/boot/dts/renesas/r9a07g043.dtsi
> > index fb6733f3cc2b..d90d263b1b13 100644
> > --- a/arch/riscv/boot/dts/renesas/r9a07g043.dtsi
> > +++ b/arch/riscv/boot/dts/renesas/r9a07g043.dtsi
> > @@ -13,6 +13,14 @@ / {
> >  	#address-cells =3D <2>;
> >  	#size-cells =3D <2>;
> >
> > +	audio_clk1: audio1-clk {
> > +		/* placeholder */
> > +	};
> > +
> > +	audio_clk2: audio2-clk {
> > +		/* placeholder */
> > +	};
> > +
> >  	cpus {
> >  		#address-cells =3D <1>;
> >  		#size-cells =3D <0>;
> > @@ -54,6 +62,19 @@ soc: soc {
> >  		#size-cells =3D <2>;
> >  		ranges;
> >
> > +		ssi1: ssi@1004a000 {
> > +			reg =3D <0 0x1004a000 0 0x400>;
> > +			#sound-dai-cells =3D <0>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		spi1: spi@1004b000 {
> > +			reg =3D <0 0x1004b000 0 0x400>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> >  		scif0: serial@1004b800 {
> >  			compatible =3D "renesas,scif-r9a07g043",
> >  				     "renesas,scif-r9a07g044";
> > @@ -73,6 +94,41 @@ scif0: serial@1004b800 {
> >  			status =3D "disabled";
> >  		};
> >
> > +		canfd: can@10050000 {
> > +			reg =3D <0 0x10050000 0 0x8000>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		i2c0: i2c@10058000 {
> > +			reg =3D <0 0x10058000 0 0x400>;
> > +			#address-cells =3D <1>;
> > +			#size-cells =3D <0>;
> > +			/* placeholder */
> > +		};
> > +
> > +		i2c1: i2c@10058400 {
> > +			reg =3D <0 0x10058400 0 0x400>;
> > +			#address-cells =3D <1>;
> > +			#size-cells =3D <0>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		adc: adc@10059000 {
> > +			reg =3D <0 0x10059000 0 0x400>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		sbc: spi@10060000 {
> > +			reg =3D <0 0x10060000 0 0x10000>,
> > +			      <0 0x20000000 0 0x10000000>,
> > +			      <0 0x10070000 0 0x10000>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> >  		cpg: clock-controller@11010000 {
> >  			compatible =3D "renesas,r9a07g043-cpg";
> >  			reg =3D <0 0x11010000 0 0x10000>;
> > @@ -104,6 +160,82 @@ pinctrl: pinctrl@11030000 {
> >  				 <&cpg R9A07G043_GPIO_SPARE_RESETN>;
> >  		};
> >
> > +		sdhi0: mmc@11c00000 {
> > +			reg =3D <0x0 0x11c00000 0 0x10000>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		sdhi1: mmc@11c10000 {
> > +			reg =3D <0x0 0x11c10000 0 0x10000>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		eth0: ethernet@11c20000 {
> > +			reg =3D <0 0x11c20000 0 0x10000>;
> > +			#address-cells =3D <1>;
> > +			#size-cells =3D <0>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		eth1: ethernet@11c30000 {
> > +			reg =3D <0 0x11c30000 0 0x10000>;
> > +			#address-cells =3D <1>;
> > +			#size-cells =3D <0>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		phyrst: usbphy-ctrl@11c40000 {
> > +			reg =3D <0 0x11c40000 0 0x10000>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		ohci0: usb@11c50000 {
> > +			reg =3D <0 0x11c50000 0 0x100>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		ohci1: usb@11c70000 {
> > +			reg =3D <0 0x11c70000 0 0x100>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		ehci0: usb@11c50100 {
> > +			reg =3D <0 0x11c50100 0 0x100>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		ehci1: usb@11c70100 {
> > +			reg =3D <0 0x11c70100 0 0x100>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		usb2_phy0: usb-phy@11c50200 {
> > +			reg =3D <0 0x11c50200 0 0x700>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		usb2_phy1: usb-phy@11c70200 {
> > +			reg =3D <0 0x11c70200 0 0x700>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		hsusb: usb@11c60000 {
> > +			reg =3D <0 0x11c60000 0 0x10000>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> >  		plic: interrupt-controller@12c00000 {
> >  			compatible =3D "renesas,r9a07g043-plic",
> "andestech,nceplic100";
> >  			#interrupt-cells =3D <2>;
> > @@ -116,5 +248,23 @@ plic: interrupt-controller@12c00000 {
> >  			resets =3D <&cpg R9A07G043_NCEPLIC_ARESETN>;
> >  			interrupts-extended =3D <&cpu0_intc 11 &cpu0_intc 9>;
> >  		};
> > +
> > +		wdt0: watchdog@12800800 {
> > +			reg =3D <0 0x12800800 0 0x400>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		ostm1: timer@12801400 {
> > +			reg =3D <0x0 0x12801400 0x0 0x400>;
> > +
> > +			/* placeholder */
> > +		};
> > +
> > +		ostm2: timer@12801800 {
> > +			reg =3D <0x0 0x12801800 0x0 0x400>;
> > +
> > +			/* placeholder */
> > +		};
> >  	};
> >  };
> > --
> > 2.25.1