Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp4419147rwb; Tue, 20 Sep 2022 13:42:51 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Csf4HHmgj9NLhguXkFCwkTi2qgDwJQWAqDv3TZS2GWiTeMWgJA2AaOmGTZoJBcxm12b56 X-Received: by 2002:a17:90b:180a:b0:202:ae1f:328a with SMTP id lw10-20020a17090b180a00b00202ae1f328amr5920378pjb.78.1663706571598; Tue, 20 Sep 2022 13:42:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663706571; cv=none; d=google.com; s=arc-20160816; b=pyx9A/FXxpaky0kPSX3quA4HQ9f2c50C0kJZClboLJ8wgFkpbK2bGEPHl4YxCUwfik aim0vfHi0rHH20A8wFV4hjyE5eDXje/RyAZaCKRm7KWxHs5wv7NKMdFIJlu4dYiDUXz3 yWOWMpMceNrnE4zv0lV0bCIs9icZdA1k+LyYwZ1F2wbvhuk8HNJOn6sNN4niW2bVALHw vrZV2tKcSxApUKj9Effc0vR5Q4MGUmzO4WwGRsLWJ4PCv+9uL497PKA5pCmO2rYhklXh igS81LgiQUn5ubgiPT6DjHx74i4eBJ0KxkdF71R06ytqzMq7li8LhDH2d1SclECY+UQx QDZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=p1WYBKPzJxS0/nMX3JitYmpQIgorQcICZWCbOg4AvPE=; b=VoqZO4LIBWyMVWw5okLuVEbHeDshZlM+RnfnTMbY2SDnlKqi7bDRkwUXU5LrXDPbM5 1EgY9Qm4ufM0frxfMDqvYhdPmoQj95WPAgOVerHI+DnQO6YW/iIPV8LSqDkiHAxFhjX+ Js1lErLKhN+XbrYCi+TbAxiwVQJl7HDN/LhmuT+U4apljZqKtDhkyvofR9AnrHtevkc+ pw9JVczJjC9IJQ+JGxZpSd5KNR0vYyloKA7d/4Ev/KV1KTvkW0BBWVY+wc9tZpXPwiEv LlhnTMh1LdCV53HFCscSfRUzT4Dj8Skefp6p5xqFvDRNMANJxyzp+6oOfrH418804zin JVEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=BnmYjNc9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m1-20020a654c81000000b00439398f09d7si602560pgt.626.2022.09.20.13.42.40; Tue, 20 Sep 2022 13:42:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=BnmYjNc9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231441AbiITTb0 (ORCPT + 99 others); Tue, 20 Sep 2022 15:31:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231440AbiITTbT (ORCPT ); Tue, 20 Sep 2022 15:31:19 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E23CA71BFE; Tue, 20 Sep 2022 12:31:18 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id sb3so8603698ejb.9; Tue, 20 Sep 2022 12:31:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=p1WYBKPzJxS0/nMX3JitYmpQIgorQcICZWCbOg4AvPE=; b=BnmYjNc9yEv+zEKdDCllEkwsoFVflf6Mua1hd5/KD2bkgzMvhc0u0GNDOvETqEeTd9 jQDUMz7XwbU9TX4nsJ1O3QA/8/0+tbnWwo49iKH2P3NpmnlNdIJ5Hmvfxtomii+nXi+V HR0CwEL08gRFQDLpsbjnPSNMPBhSdRPD76o9XaCSbuaD9kpHyI7xF+qmlKL9QLE6bMj0 sZsLFHfhDpdpvX2Q7V0Dwu5avfoFREFGf8wXk270rw7RRm5ml5Gv08TxA3XmX0x7/mKa wR26Sh2CHEqWhF7nk0d7LO86UESkA3oKNhOLxS5AgFyuluAbU7ehs+6U0R2fhy9QMdkr uWPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=p1WYBKPzJxS0/nMX3JitYmpQIgorQcICZWCbOg4AvPE=; b=igS0uGjprx/Qbr0UWlieEdPTgnMU2WCTf0xkEdP26F7QoT+vjEi/7ltEh3sjIKjPrO eX56zUXBO+z0PigPePZI/MY6MbbR3wmwM9xnQrGEyDTb2Ava/ZGneDW5xj3DB40F7H7H RsBI+B+pD+V6fEM8v8KZqKKI/a17mX4mbmKiyk9j4VnX5SbTHddvKdODvaApTF8Tr/hJ HxzmX1cYYqMVW9TsPwnB4Ozpq8EjzrzoIiIqpp5wKBylCr+4dmA55uatuFQWKW3ZfMm/ XYAzwTtrlABjX/ZNFGZnkpWrLY46PO3oufmhD2+yzNOG7fW5sr9tV2SHqyvtcyojOYfs cpRQ== X-Gm-Message-State: ACrzQf1Gt9XCzy3bDC3G1Mnh4xG2QnopGes2tsae/kxlzkXJyQvMt6XJ bairsEdJNA97PoM4g6lVxNBcm7B0i3yArSTXaFY= X-Received: by 2002:a17:907:74a:b0:77e:9455:b4e3 with SMTP id xc10-20020a170907074a00b0077e9455b4e3mr18447476ejb.471.1663702277120; Tue, 20 Sep 2022 12:31:17 -0700 (PDT) MIME-Version: 1.0 References: <20220917022602.3843619-1-floridsleeves@gmail.com> <20220920113744.64b16924@kernel.org> In-Reply-To: <20220920113744.64b16924@kernel.org> From: Li Zhong Date: Tue, 20 Sep 2022 12:31:29 -0700 Message-ID: Subject: Re: [PATCH v1] net/ethtool/tunnels: check the return value of nla_nest_start() To: Jakub Kicinski Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com, davem@davemloft.net Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2022 at 11:37 AM Jakub Kicinski wrote: > > On Fri, 16 Sep 2022 19:26:02 -0700 Li Zhong wrote: > > goto err_cancel_table; > > > > entry = nla_nest_start(skb, ETHTOOL_A_TUNNEL_UDP_TABLE_ENTRY); > > + if (!entry) > > + return -EMSGSIZE; > > not even correct, and completely harmless Thanks for your reply. Maybe a more suitable way of error handling is 'goto err_cancel_table;'?